From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63243C433B4 for ; Wed, 28 Apr 2021 23:06:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C6B961059 for ; Wed, 28 Apr 2021 23:06:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbhD1XHV (ORCPT ); Wed, 28 Apr 2021 19:07:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229593AbhD1XHT (ORCPT ); Wed, 28 Apr 2021 19:07:19 -0400 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1234BC06138C for ; Wed, 28 Apr 2021 16:06:32 -0700 (PDT) Received: by mail-qk1-x72f.google.com with SMTP id 8so31693012qkv.8 for ; Wed, 28 Apr 2021 16:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zh7OlMvW3DerlpqnUGmUulKmpWmcH2OBnD2WoZd3s2E=; b=YmSZOiKx330MTi6OgPxfVQAMQcngQCx0VixjfYfa8oimpEQdKQgtVXk/+sdhYuWHBk INJua3d8nJs4sB3DuURU4LOBXXJvRHtnO9z2pzNUOsZJqxJ/lu/MSd8Zk7zaJlk6X+3b wV1t6QWmPYLQjSAqEZt/q6B+HAPDWWap6PV+FVd7Z7vMjm/zlLW6fC30urIy9Ixi1Zow C+B1TJrtu6N0ov6PxdLuPTBDL8VD0zEtoFnb74RMkjl9oi1MKgNdiBJgV1HNSjGVv/Fl L/AR4xnQA6V3mj7Yb0eu1tgO/5mcDwYATZi63am5SCwGLOOEX5cnBhXezwGWRTelTvHJ begg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zh7OlMvW3DerlpqnUGmUulKmpWmcH2OBnD2WoZd3s2E=; b=kc+zwEKwCOPhZCrQLcfGAgwkBaa5S4lixkXX7uzIX7jtlIn7SXu166Xli21y/+KwNJ 5Fvdh1LUGG2q7bzJqe83UO89gViIehBYpP38TI764yJK5P7uiUDBrMGv03F/p4hMG5SV LvVukG0Nwg1zRM4BcfL6hFHZJGLBYmlpbT8nsGhmsjOrUXCaO/jqPPTisCUXigb04qsm 2iURwEi23bscimAUXlnP8N7cOWdKneKFaVTKGhcAxhaJAkZfnGE6fPSbifQZh8/YS0KB OjWFCGUEgGTO99zh2QyTB6cNMRJdPcKHm8YwRSNQM0zxa2uQ0jcjKiffMP5LP/ikNuoT VwEg== X-Gm-Message-State: AOAM5308hdB87swT1cdM7+1IUXBznqsTmMoMks1xfdVo+je4vCwVbs/c 47BQPicWlIETq/TKGhDxiv0SRzviVHsmjM06I0FH9Q== X-Google-Smtp-Source: ABdhPJyP5Rq2TRUvGNCzXQ1TVtatDBGYjPsbD4BIYz1E9VvNk25ly9hWjYmcb76DZ6leGHtwS5fr3IhvvwXH1Fuxrjw= X-Received: by 2002:a05:620a:70e:: with SMTP id 14mr31567987qkc.278.1619651190787; Wed, 28 Apr 2021 16:06:30 -0700 (PDT) MIME-Version: 1.0 References: <20210419165323.v1.1.I9f9e8bcc849d91c1bb588a5181317c3e2ad48461@changeid> In-Reply-To: <20210419165323.v1.1.I9f9e8bcc849d91c1bb588a5181317c3e2ad48461@changeid> From: Yu Liu Date: Wed, 28 Apr 2021 16:05:54 -0700 Message-ID: Subject: Re: [PATCH v1] Bluetooth: Fix the HCI to MGMT status conversion table To: linux-bluetooth@vger.kernel.org, Marcel Holtmann Cc: "David S. Miller" , Jakub Kicinski , Johan Hedberg , Luiz Augusto von Dentz , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Ping for attention, thanks. On Mon, Apr 19, 2021 at 4:53 PM Yu Liu wrote: > > 0x2B, 0x31 and 0x33 are reserved for future use but were not present in > the HCI to MGMT conversion table, this caused the conversion to be > incorrect for the HCI status code greater than 0x2A. > > Reviewed-by: Miao-chen Chou > Signed-off-by: Yu Liu > --- > > Changes in v1: > - Initial change > > net/bluetooth/mgmt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c > index 40f75b8e1416..b44e19c69c44 100644 > --- a/net/bluetooth/mgmt.c > +++ b/net/bluetooth/mgmt.c > @@ -252,12 +252,15 @@ static const u8 mgmt_status_table[] = { > MGMT_STATUS_TIMEOUT, /* Instant Passed */ > MGMT_STATUS_NOT_SUPPORTED, /* Pairing Not Supported */ > MGMT_STATUS_FAILED, /* Transaction Collision */ > + MGMT_STATUS_FAILED, /* Reserved for future use */ > MGMT_STATUS_INVALID_PARAMS, /* Unacceptable Parameter */ > MGMT_STATUS_REJECTED, /* QoS Rejected */ > MGMT_STATUS_NOT_SUPPORTED, /* Classification Not Supported */ > MGMT_STATUS_REJECTED, /* Insufficient Security */ > MGMT_STATUS_INVALID_PARAMS, /* Parameter Out Of Range */ > + MGMT_STATUS_FAILED, /* Reserved for future use */ > MGMT_STATUS_BUSY, /* Role Switch Pending */ > + MGMT_STATUS_FAILED, /* Reserved for future use */ > MGMT_STATUS_FAILED, /* Slot Violation */ > MGMT_STATUS_FAILED, /* Role Switch Failed */ > MGMT_STATUS_INVALID_PARAMS, /* EIR Too Large */ > -- > 2.31.1.368.gbe11c130af-goog >