From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D1CC56202 for ; Mon, 23 Nov 2020 23:47:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E6D820717 for ; Mon, 23 Nov 2020 23:47:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="bahMHd+3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727566AbgKWXrc (ORCPT ); Mon, 23 Nov 2020 18:47:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727519AbgKWXra (ORCPT ); Mon, 23 Nov 2020 18:47:30 -0500 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE4D8C061A4D for ; Mon, 23 Nov 2020 15:47:29 -0800 (PST) Received: by mail-ej1-x642.google.com with SMTP id bo9so20058087ejb.13 for ; Mon, 23 Nov 2020 15:47:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M2tH0J5FjG3CWEJAM78SzCWVNgxFS8dPSbJZXIrz8eA=; b=bahMHd+33ExZBCoE/oR5FMEwH44L39inSA9W3/K3d6bGAEZkB7v1ob5roD/5eVpdJ0 R+d0XQDrBNNwKmyj7FajR++y38fX39bQnAMu70cGakDlYcC/tW05dSTKflWZ2uAoQW9m 2xCdSEgInNLrNTxIFKbecjjgDab/K6ZMjJKwyzFIhhQORgKViMZWnZTGdz20711EZ5ci U2ly/ZtfiZq+0PY0skLkv4AYzqD+mof+cpmMKy3FSM3JxLk/gPf8GN2BxGNVXsoFg84t 6g1MHkNlmtLw9gyrB0EbPGvW8Ijj9ZPRVocIwgwJMvyatG/WkP6v3iQP7tU7LfrtZ+GZ 47zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M2tH0J5FjG3CWEJAM78SzCWVNgxFS8dPSbJZXIrz8eA=; b=b7HJ7/Y0zbu3zahUelQJE+8fnJcAKcPLUczwlYfWnRbLKwuXOXyHAyOuG1yjDHl9IW 6yqq52FFSsTai75HtE1hWBE0c3D5KTgeX4yEXaWP5t0Jkl0Xfjr4nkU3wQtfB4WB365J qkQSGUBvuLIu8DNKNoizYiAsiN+VToezU4vfWMZT4fEuuh+5IQUoewPgWdhjrEC8aNSw H7V8goFYiG5zWA3v32z4Bz3ERzjRTAe3Zsft/jl1GXakoSNYpyUG+URS0A/wfaiOaUlL lEAo3qr7b9wx2Fx9jNPDBVKHRBOPItXzOEI+nhvEyf4Jk4KRi9cyibUlKYeXHWRBNmpY Y/mA== X-Gm-Message-State: AOAM5325stduT7MOwph/j19exW+JSSeexZRflzw8J0GjO2Kcx7c3LZJT o8CbPQshtQ9TYCvtlKb3dMNHMSItsRoMTeK7+dXj X-Google-Smtp-Source: ABdhPJz1cUzeMfwEdEEYptfkLKXDQKCaDHJLy6k80ocYA5tN4wZuhgjNHiuJKbzQ6wUqWl7pFgW3ifxoIkY/SNwNlKM= X-Received: by 2002:a17:906:46d6:: with SMTP id k22mr1808743ejs.542.1606175248555; Mon, 23 Nov 2020 15:47:28 -0800 (PST) MIME-Version: 1.0 References: <160581265397.2575.2287441525647057669.stgit@sifl> In-Reply-To: From: Paul Moore Date: Mon, 23 Nov 2020 18:47:17 -0500 Message-ID: Subject: Re: [PATCH] lsm,selinux: pass flowi_common instead of flowi to the LSM hooks To: James Morris Cc: linux-security-module@vger.kernel.org, netdev@vger.kernel.org, selinux@vger.kernel.org, Herbert Xu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Nov 19, 2020 at 10:02 PM James Morris wrote: > On Thu, 19 Nov 2020, Paul Moore wrote: > > As pointed out by Herbert in a recent related patch, the LSM hooks do > > not have the necessary address family information to use the flowi > > struct safely. As none of the LSMs currently use any of the protocol > > specific flowi information, replace the flowi pointers with pointers > > to the address family independent flowi_common struct. > > > > Reported-by: Herbert Xu > > Signed-off-by: Paul Moore > > Acked-by: James Morris Thanks. Seeing no further comments or objections, and given the discussion in the previous draft of the patch, I've gone again and merged this into selinux/next. -- paul moore www.paul-moore.com