netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michał Mirosław" <mirqus@gmail.com>
To: greearb@candelatech.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/5] send-crc: Add framework to allow sending packets with customized CRC.
Date: Tue, 7 Feb 2012 21:33:29 +0100	[thread overview]
Message-ID: <CAHXqBFKe+nAGk8gjjOxRSbgtPSPHXcz3_fNjaBaxh48vPvDysQ@mail.gmail.com> (raw)
In-Reply-To: <1328644182-7872-1-git-send-email-greearb@candelatech.com>

2012/2/7  <greearb@candelatech.com>:
> From: Ben Greear <greearb@candelatech.com>
>
> This is useful for testing RX handling of frames with bad
> CRCs.
>
> Requires driver support to actually put the packet on the
> wire properly.
[...]

I like this idea. I think that this is not a feature to have in
dev->features to toggle, though. Driver either supports this or not,
so it's better to put it in dev->priv_flags instead. Disabling of FCS
inserting is a per-packet option in the drivers, isn't it?

For one problem with toggling: if you create a socket using it and
later turn off the feature, the socket will still send skbs with FCS
appended.

Best Regards,
Michał Mirosław

  parent reply	other threads:[~2012-02-07 20:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-07 19:49 [PATCH 1/5] send-crc: Add framework to allow sending packets with customized CRC greearb
2012-02-07 19:49 ` [PATCH 2/5] e100: Support sending custom Ethernet CRC greearb
2012-02-07 19:49 ` [PATCH 3/5] e1000e: " greearb
2012-02-07 20:33 ` Michał Mirosław [this message]
2012-02-07 20:43   ` [PATCH 1/5] send-crc: Add framework to allow sending packets with customized CRC Ben Greear
2012-02-07 23:59     ` Michał Mirosław
2012-02-08  0:06       ` Ben Greear
2012-02-08  8:02 ` Jeff Kirsher
2012-02-08 15:55   ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHXqBFKe+nAGk8gjjOxRSbgtPSPHXcz3_fNjaBaxh48vPvDysQ@mail.gmail.com \
    --to=mirqus@gmail.com \
    --cc=greearb@candelatech.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).