From: Catherine Sullivan <csully@google.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Sagi Shahar <sagis@google.com>,
Jon Olson <jonolson@google.com>,
Willem de Bruijn <willemb@google.com>,
Luigi Rizzo <lrizzo@google.com>
Subject: Re: [net-next 2/4] gve: Add transmit and receive support
Date: Fri, 28 Jun 2019 10:50:10 -0700 [thread overview]
Message-ID: <CAH_-1qwQZz5H9uQn21Vuob8PKs0-SNYh21=Q+G064OkLUUrzTQ@mail.gmail.com> (raw)
In-Reply-To: <20190626194203.GF27733@lunn.ch>
On Wed, Jun 26, 2019 at 12:42 PM Andrew Lunn <andrew@lunn.ch> wrote:
>
> > +static int gve_change_mtu(struct net_device *dev, int new_mtu)
> > +{
> > + dev->mtu = new_mtu;
> > + return 0;
> > +}
>
> The default implementation does this.
>
> Also, i think your mtu has a limit of PAGE size. So you should set
> the dev->max_mtu so the core will enforce this.
>
> Andrew
Ah, thanks, gve_change_mtu will be removed in v2.
We already set dev->max_mtu to PAGE_SIZE in init_priv.
next prev parent reply other threads:[~2019-06-28 17:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 18:52 [net-next 0/4] Add gve driver Catherine Sullivan
2019-06-26 18:52 ` [net-next 1/4] gve: Add basic driver framework for Compute Engine Virtual NIC Catherine Sullivan
2019-06-26 19:35 ` Andrew Lunn
2019-06-28 17:54 ` Catherine Sullivan
2019-06-26 23:08 ` Jakub Kicinski
2019-06-28 17:52 ` Catherine Sullivan
2019-06-28 18:46 ` Jakub Kicinski
2019-06-28 20:06 ` Andrew Lunn
2019-06-28 23:05 ` Catherine Sullivan
2019-06-29 2:21 ` kbuild test robot
2019-06-29 2:21 ` [RFC PATCH] gve: gve_version_prefix[] can be static kbuild test robot
2019-06-29 10:25 ` [net-next 1/4] gve: Add basic driver framework for Compute Engine Virtual NIC kbuild test robot
2019-06-26 18:52 ` [net-next 2/4] gve: Add transmit and receive support Catherine Sullivan
2019-06-26 19:42 ` Andrew Lunn
2019-06-28 17:50 ` Catherine Sullivan [this message]
2019-06-26 19:49 ` David Miller
2019-06-28 17:48 ` Catherine Sullivan
2019-06-29 4:13 ` kbuild test robot
2019-06-29 4:13 ` [RFC PATCH] gve: gve_napi_poll() can be static kbuild test robot
2019-06-29 11:30 ` [net-next 2/4] gve: Add transmit and receive support kbuild test robot
2019-06-26 18:52 ` [net-next 3/4] gve: Add workqueue and reset support Catherine Sullivan
2019-06-26 18:52 ` [net-next 4/4] gve: Add ethtool support Catherine Sullivan
2019-06-26 19:48 ` Andrew Lunn
2019-06-28 17:42 ` Catherine Sullivan
2019-06-29 2:44 ` Florian Fainelli
2019-07-01 23:37 ` Catherine Sullivan
2019-06-29 6:40 ` kbuild test robot
2019-06-29 6:40 ` [RFC PATCH] gve: gve_get_channels() can be static kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH_-1qwQZz5H9uQn21Vuob8PKs0-SNYh21=Q+G064OkLUUrzTQ@mail.gmail.com' \
--to=csully@google.com \
--cc=andrew@lunn.ch \
--cc=jonolson@google.com \
--cc=lrizzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=sagis@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).