From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71EA5C433FE for ; Thu, 12 May 2022 17:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356958AbiELRTu (ORCPT ); Thu, 12 May 2022 13:19:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356945AbiELRTr (ORCPT ); Thu, 12 May 2022 13:19:47 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02B4B26AD8C for ; Thu, 12 May 2022 10:19:46 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id w24so7082068edx.3 for ; Thu, 12 May 2022 10:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jDHOqKOOly/u6UGesDlSvrOYIRtvk+Gi75eJQoAcvU8=; b=ajie93GkyM3bMzgPSyr9+zDuLO8qmNsBGOmDLDAYe2chL7Y1Dex40FgP7wpA+YsFVS PbCwBPFRrhD1wKMyrktSA2hu4sY+A8Snezdkh2Pl31GtbbWKUVs17izWFz1kX+D2q2GT 3Kh1nj3RjFExJpH9SEac2MgWbeFHQCaqrxqgg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jDHOqKOOly/u6UGesDlSvrOYIRtvk+Gi75eJQoAcvU8=; b=xChv8InDcxLnvIstOcqYGHKBVQGBJa7f6xbA+B9XRgagY7k/1S3nmVMjYOT+cJ++z2 sn8L1NgBpTgDKvta4jUDk4gDSp3T6GV3vr1v2uAzVKP+Qtu+7f6a0Gn0Xcn11JloMSC5 1nAfY322oZEzFRLait/Boyl/RBr7e/axwhs6oP7bMPkVDdgSBokxOuoPhZMXtrMbjCh5 mQzV71LrzvyuNWcnVVmtpsGWSYOkFFdtf2CTYrwMt8qAften+SxZMfYgkXE1YGK/DeuG cN5U/AF5XJvTtecM0wGcOsTFXGmbAt7KvVmb2f1TwNiG0D3zjX9q+p3OjlC7XuKHRT8x V87Q== X-Gm-Message-State: AOAM532gJVO/p4M8XpJ+KN+eET+GYSW5Fp/wCclf+j/j/MTp//VOA+LK brzLmN6lfbY+2mX1MK4y0RZ/4fWnoSqSVyahp4w= X-Google-Smtp-Source: ABdhPJycAjODf+Asp4SXkq/HSraZcqSxYiEo6OOnjITHEyuccGr4g68m4YMDVZIsXLysZkwA+Eooaw== X-Received: by 2002:a05:6402:28b1:b0:425:c39e:b773 with SMTP id eg49-20020a05640228b100b00425c39eb773mr35542555edb.237.1652375984307; Thu, 12 May 2022 10:19:44 -0700 (PDT) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com. [209.85.221.45]) by smtp.gmail.com with ESMTPSA id rk6-20020a170907214600b006f3ef214dd9sm2255908ejb.63.2022.05.12.10.19.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 10:19:41 -0700 (PDT) Received: by mail-wr1-f45.google.com with SMTP id b19so8166125wrh.11 for ; Thu, 12 May 2022 10:19:41 -0700 (PDT) X-Received: by 2002:a5d:6dad:0:b0:20c:4dc1:e247 with SMTP id u13-20020a5d6dad000000b0020c4dc1e247mr629061wrs.274.1652375980629; Thu, 12 May 2022 10:19:40 -0700 (PDT) MIME-Version: 1.0 References: <20220510082351-mutt-send-email-mst@kernel.org> <87czgk8jjo.fsf@mpe.ellerman.id.au> <87mtfm7uag.fsf@mpe.ellerman.id.au> In-Reply-To: From: Linus Torvalds Date: Thu, 12 May 2022 10:19:24 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] virtio: last minute fixup To: Michael Ellerman Cc: "Michael S. Tsirkin" , Konstantin Ryabitsev , KVM list , virtualization@lists.linux-foundation.org, Netdev , Linux Kernel Mailing List , mie@igel.co.jp Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, May 12, 2022 at 10:10 AM Linus Torvalds wrote: > > And most definitely not just random data that can be trivially > auto-generated after-the-fact. Put another way: when people asked for change ID's and I said "we have links", I by no means meant that "you can just add random worthless links to commits". For example, if you have a (public-facing) Gerrit system that tracks a patch before it gets committed, BY ALL MEANS add a link to that as the "change ID" that you tracked in Gerrit. That's a Link: that actually adds *information*. It shows some real history to the commit, and shows who approved it and when, and gives you all the Gerrit background. But a link to the email on lkml that just contains the patch and the same commentary that was introduced into the commit? Useless garbage. It adds no actual information. THAT is my argument. Why do people think I'm arguing against the Link: tag? No. I'm arguing against adding links with no relevant new information behind them. I don't argue against links to lore. Not at all. If those links are about the background that caused the patch, they are great. Maybe they are to a long thread about the original problem and how to solve it. Thats WONDERFUL. But here's the deal: when I look at a commit that I wonder "why is it doing this, it seems wrong" (possibly after there's been a bug report about it, but possibly just because I'm reviewing it as part of doing the pull), and I see a "Link:" tag, and it just points back to the SAME DAMN DATA that I already have in the commit, then that Link: tag not only wasn't helpful, it was ACTIVELY DETRIMENTAL and made me waste time and just get irritated. And if you waste my time with useless links, why would you expect me to be supportive of that behavior? Linus