From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CD11C2D0C3 for ; Fri, 27 Dec 2019 22:13:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31ADC20828 for ; Fri, 27 Dec 2019 22:13:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577484807; bh=iZnqzqDa4efObkwi/oGhOaDMX+KempluIoxxYoO/E5w=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=m7QRTvaXUDwfnl5JF4tP910hBALiYx2VXKUveqgiCcCykx6bPFVY25leI8RXR5+uC PdCaV7g7v2+HQhLvS1p8CGNUxR3khi/74uW9Y+xdsiwTLcTd+JsPYKNPBdkfF8q1fT jL7yQiRyBQZQ/+ul46LzDsbfnICsY9DSPWyKEtDA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726407AbfL0WNZ (ORCPT ); Fri, 27 Dec 2019 17:13:25 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:33800 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725957AbfL0WNX (ORCPT ); Fri, 27 Dec 2019 17:13:23 -0500 Received: by mail-lf1-f68.google.com with SMTP id l18so13372335lfc.1 for ; Fri, 27 Dec 2019 14:13:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TzNDgewdty9+XCRaXDaU2bPI7xNE/bDJBnpHNO7m5MI=; b=eXwiGLZOx9BivEyNJf7zzgLYHeRiMJI1uecqF8smMsuOgs+Cx53GMofDb4oWPS3MGQ BIGX05y8iL3+DicrPwXvF3BPXyBut0xRzAix260rRPvJOGlkag7p9e2Li+ta+DW4rH92 vmo8HQ9NZJTCKxHKlc/BhYmbqDJhF15/q1dNE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TzNDgewdty9+XCRaXDaU2bPI7xNE/bDJBnpHNO7m5MI=; b=d7pMidGmgBtWwVUsIrPRMQTHx8rTtdQ5XbufYZpogfCn+DGCpgXQUW0NZK9z2CKX8V 2SXovMiIUvZ7xmH4k6Dlw9ETlyhqo7sK6w5N9oOoasexMTSPbu1mG+o+rg5Cl41OL9Xc GLJwGET1aXadBMKkRS1GfvXG+dv1UNen34rn7G9ENPgBBVFnAodoFo80J08CodiC1/zs vini+Bc8a4eS05wikmxP++heWmP91ZoAfeQCitvAUA5g1l0QsczV2hltjopkHFrSSZzD V3t58+ONoJ5hTzPHI1BTwMNAMfbAfH65CdVAReieTK+IZXW4lot5XKxC7e+ZZHK7WKwi /qLg== X-Gm-Message-State: APjAAAXi8U2zU+EYKy85BmdQ4etD/GwvXswpQt/v6H6h6kZNhr6wDRR5 d/s0Jf02EkkuCPG7Oe07h0JOlwSwXNQ= X-Google-Smtp-Source: APXvYqyn5HeYfmXLCI4pzOAcxnQIXLKgDhgSST3E3gUNHt64ZsJJVWmLWXCPhcOEjuBqNd4OZXphaw== X-Received: by 2002:a19:710a:: with SMTP id m10mr29830742lfc.58.1577484801243; Fri, 27 Dec 2019 14:13:21 -0800 (PST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com. [209.85.208.174]) by smtp.gmail.com with ESMTPSA id c189sm15302513lfg.75.2019.12.27.14.13.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Dec 2019 14:13:20 -0800 (PST) Received: by mail-lj1-f174.google.com with SMTP id w1so6124991ljh.5 for ; Fri, 27 Dec 2019 14:13:20 -0800 (PST) X-Received: by 2002:a2e:8946:: with SMTP id b6mr27871105ljk.1.1577484799595; Fri, 27 Dec 2019 14:13:19 -0800 (PST) MIME-Version: 1.0 References: <20191221.180914.601367701836089009.davem@davemloft.net> In-Reply-To: <20191221.180914.601367701836089009.davem@davemloft.net> From: Linus Torvalds Date: Fri, 27 Dec 2019 14:13:03 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT] Networking To: David Miller , Antoine Tenart Cc: Andrew Morton , Netdev , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Dec 21, 2019 at 6:09 PM David Miller wrote: > > Antoine Tenart (2): > of: mdio: export of_mdiobus_child_is_phy I didn't notice until now (bad me - I've actually been taking a few days off due to xmas), but this causes a new warning in some configurations. In particular, it causes a warning about 'of_mdiobus_child_is_phy' defined but noy used because when CONFIG_OF_MDIO is disabled, the header now has static bool of_mdiobus_child_is_phy(struct device_node *child) { return false; } which is all kinds of stupid. I'm assuming that dummy function should just be marked "inline", the way the other helper dummy functions are defined when OF_MDIO is not enabled. Linus