From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: David Miller <davem@davemloft.net>
Cc: Netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] ipv6: do not free rt if FIB_LOOKUP_NOREF is set on suppress rule
Date: Tue, 24 Sep 2019 15:49:59 +0200 [thread overview]
Message-ID: <CAHmME9oL7qP=pGnXRT1hmPmRpQ1_0r__vHkuBe-LbfgZTEMV_g@mail.gmail.com> (raw)
In-Reply-To: <20190924.153008.1663682877890370513.davem@davemloft.net>
On Tue, Sep 24, 2019 at 3:30 PM David Miller <davem@davemloft.net> wrote
> I'm asking you to make a non-wireguard test that triggers the problem.
Oh, gotcha. No problem.
>
> Or would you like a situation you're interested in to break from time
> to time.
My test suite should catch it in the future now that it's there, so I'm fine.
> Jason, please don't be difficult about this and write a proper test
> case just like I would ask anyone else fixing bugs like this to write.
I'm not being difficult. I just thought you didn't see what the test
case I linked to actually was. I have no qualms about reimplementing
it with the dummy interface, for a v2 of this patch. Coming your way
shortly.
next prev parent reply other threads:[~2019-09-24 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 7:36 [PATCH] ipv6: do not free rt if FIB_LOOKUP_NOREF is set on suppress rule Jason A. Donenfeld
2019-09-24 9:35 ` Jason A. Donenfeld
2019-09-24 12:52 ` David Miller
2019-09-24 12:55 ` Jason A. Donenfeld
2019-09-24 13:30 ` David Miller
2019-09-24 13:49 ` Jason A. Donenfeld [this message]
2019-09-24 14:01 ` [PATCH v2] " Jason A. Donenfeld
2019-09-24 17:02 ` Wei Wang
2019-09-26 7:35 ` David Miller
2019-09-26 14:43 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9oL7qP=pGnXRT1hmPmRpQ1_0r__vHkuBe-LbfgZTEMV_g@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).