From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: "Simo Sorce" <simo@redhat.com>, Netdev <netdev@vger.kernel.org>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Ondrej Mosnacek" <omosnace@redhat.com>,
"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode
Date: Thu, 8 Apr 2021 20:44:35 -0600 [thread overview]
Message-ID: <CAHmME9oqK9iXRn3wxAB-MZvX3k_hMbtjHF_V9UY96u6NLcczAw@mail.gmail.com> (raw)
In-Reply-To: <20210409024143.GL2900@Leo-laptop-t470s>
Hi Hangbin,
On Thu, Apr 8, 2021 at 8:41 PM Hangbin Liu <liuhangbin@gmail.com> wrote:
> I agree that the best way is to disable the crypto modules in FIPS mode.
> But the code in lib/crypto looks not the same with crypto/. For modules
> in crypto, there is an alg_test() to check if the crytpo is FIPS allowed
> when do register.
>
> - crypto_register_alg()
> - crypto_wait_for_test()
> - crypto_probing_notify(CRYPTO_MSG_ALG_REGISTER, larval->adult)
> - cryptomgr_schedule_test()
> - cryptomgr_test()
> - alg_test()
>
> But in lib/crypto the code are more like a library. We can call it anytime
> and there is no register. Maybe we should add a similar check in lib/crypto.
> But I'm not familiar with crypto code... Not sure if anyone in linux-crypto@
> would like help do that.
Since it's just a normal module library, you can simply do this in the
module_init function, rather than deep within registration
abstractions.
> > diff --git a/lib/crypto/curve25519.c b/lib/crypto/curve25519.c
> > index 288a62cd29b2..b794f49c291a 100644
> > --- a/lib/crypto/curve25519.c
> > +++ b/lib/crypto/curve25519.c
> > @@ -12,11 +12,15 @@
> > #include <crypto/curve25519.h>
> > #include <linux/module.h>
> > #include <linux/init.h>
> > +#include <linux/fips.h>
> >
> > bool curve25519_selftest(void);
> >
> > static int __init mod_init(void)
> > {
> > + if (!fips_enabled)
> > + return -EOPNOTSUPP;
>
> Question here, why it is !fips_enabled? Shouldn't we return error when
> fips_enabled?
Er, just not thinking straight today. `if (fips_enabled)` is probably
what you want indeed.
Jason
next prev parent reply other threads:[~2021-04-09 2:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 11:39 [PATCH net-next] [RESEND] wireguard: disable in FIPS mode Hangbin Liu
2021-04-07 21:12 ` Eric Biggers
2021-04-08 1:06 ` Hangbin Liu
2021-04-08 11:58 ` Hangbin Liu
2021-04-08 15:11 ` Eric Biggers
2021-04-09 2:11 ` Hangbin Liu
2021-04-09 7:08 ` Stephan Mueller
2021-04-09 8:08 ` Hangbin Liu
2021-04-09 16:26 ` Simo Sorce
2021-04-09 18:29 ` Jason A. Donenfeld
2021-04-12 2:11 ` Hangbin Liu
2021-04-07 21:15 ` Jason A. Donenfeld
2021-04-08 6:52 ` Hangbin Liu
2021-04-08 7:36 ` Ondrej Mosnacek
2021-04-08 13:55 ` Simo Sorce
2021-04-08 21:55 ` Jason A. Donenfeld
2021-04-08 22:16 ` Simo Sorce
2021-04-09 2:41 ` Hangbin Liu
2021-04-09 2:44 ` Jason A. Donenfeld [this message]
2021-04-09 2:49 ` Hangbin Liu
2021-04-09 3:03 ` Jason A. Donenfeld
2021-04-09 6:02 ` Ard Biesheuvel
2021-04-09 12:47 ` Simo Sorce
2021-04-09 18:36 ` Jason A. Donenfeld
2021-04-09 18:56 ` Simo Sorce
2021-04-12 12:46 ` Simo Sorce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9oqK9iXRn3wxAB-MZvX3k_hMbtjHF_V9UY96u6NLcczAw@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=kuba@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=simo@redhat.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).