From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
Netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Peter Zijlstra" <peterz@infradead.org>,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Subject: Re: [PATCH net-next] net: Add lockdep asserts to ____napi_schedule().
Date: Fri, 18 Mar 2022 18:41:18 -0600 [thread overview]
Message-ID: <CAHmME9q4dKNtArpbsUbFv_Hg4BGEJ58GfRFMujQV5cZf36qFvw@mail.gmail.com> (raw)
In-Reply-To: <20220318115920.71470819@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hey Jakub,
On Fri, Mar 18, 2022 at 12:59 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Fri, 18 Mar 2022 12:19:45 -0600 Jason A. Donenfeld wrote:
> > > In your case it is "okay" since that ptr_ring_consume_bh() will do BH
> > > disable/enable which forces the softirq to run. It is not obvious.
> >
> > In that case, isn't the lockdep assertion you added wrong and should
> > be reverted? If correct code is hitting it, something seems wrong...
>
> FWIW I'd lean towards revert as well, I can't think of a simple
> fix that won't require work arounds in callers.
I just got an email from syzbot about this too:
https://lore.kernel.org/wireguard/0000000000000eaff805da869d5b@google.com/
And no word from Sebastian, and now it's the weekend, so I suspect
you're probably right. I'll send in a revert.
Jason
prev parent reply other threads:[~2022-03-19 0:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 15:03 [PATCH net-next] net: Add lockdep asserts to ____napi_schedule() Sebastian Andrzej Siewior
2022-03-14 10:40 ` patchwork-bot+netdevbpf
2022-03-17 19:21 ` Saeed Mahameed
2022-03-18 10:05 ` Sebastian Andrzej Siewior
2022-03-18 1:48 ` Jason A. Donenfeld
2022-03-18 10:57 ` Sebastian Andrzej Siewior
2022-03-18 18:19 ` Jason A. Donenfeld
2022-03-18 18:59 ` Jakub Kicinski
2022-03-19 0:41 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9q4dKNtArpbsUbFv_Hg4BGEJ58GfRFMujQV5cZf36qFvw@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).