From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net 3/3] wireguard: send: account for mtu=0 devices
Date: Fri, 14 Feb 2020 16:56:22 +0100 [thread overview]
Message-ID: <CAHmME9qErQbU5Y36i=3L_R_PYw2Li_Vv2a9k7bSuMxpuLMcgsg@mail.gmail.com> (raw)
In-Reply-To: <ba6b4c66-3c15-cdbc-7d0e-eaf307c5904c@gmail.com>
On Fri, Feb 14, 2020 at 4:18 PM Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > However, while min_mtu=0 seems fine, it makes sense to restrict the
> > max_mtu. This commit also restricts the maximum MTU to the greatest
> > number for which rounding up to the padding multiple won't overflow a
> > signed integer. Packets this large were always rejected anyway
> > eventually, due to checks deeper in, but it seems more sound not to even
> > let the administrator configure something that won't work anyway.
> >
> If mtu is set to 0, the device must not send any payload.
Yes, but there's still internal keepalive messages.
>
> Are you sure this works ?
>
> Last statement :
>
> return padded_size - last_unit;
>
> will return a a ' negative number'
Woah nelly I don't know how I missed this. Thanks! Will send a v2 of
this patchset.
prev parent reply other threads:[~2020-02-14 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 13:34 [PATCH net 0/3] wireguard fixes for 5.6-rc2 Jason A. Donenfeld
2020-02-14 13:34 ` [PATCH net 1/3] wireguard: selftests: reduce complexity and fix make races Jason A. Donenfeld
2020-02-14 13:34 ` [PATCH net 2/3] wireguard: receive: reset last_under_load to zero Jason A. Donenfeld
2020-02-14 13:34 ` [PATCH net 3/3] wireguard: send: account for mtu=0 devices Jason A. Donenfeld
2020-02-14 15:18 ` Eric Dumazet
2020-02-14 15:56 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHmME9qErQbU5Y36i=3L_R_PYw2Li_Vv2a9k7bSuMxpuLMcgsg@mail.gmail.com' \
--to=jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).