From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95F62C48BE8 for ; Mon, 14 Jun 2021 08:08:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79F1D61380 for ; Mon, 14 Jun 2021 08:08:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232609AbhFNIKm (ORCPT ); Mon, 14 Jun 2021 04:10:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232530AbhFNIKl (ORCPT ); Mon, 14 Jun 2021 04:10:41 -0400 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFE2DC061574; Mon, 14 Jun 2021 01:08:38 -0700 (PDT) Received: by mail-qk1-x736.google.com with SMTP id i68so33967596qke.3; Mon, 14 Jun 2021 01:08:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3Z9QCuBnaG3V0M5rfTL5FcVGUPaAvk8s7UrMizywBSc=; b=ClGamw/5HpYmv7E1SCdvUh0NthGaWpompaCbLLfoIfhcLKlDnAS/tJQnj5oj2hcXX7 UOYP58ofwNo/ByqHuxs0zcnHKz6+5JTMTEUfpuWBGKHFMih0KYwUX0r7JaDUf55U44kE rcQwC1AyoyEW9PxVy18y5+DWnH5Bl0+ZaXphAbGI7hFRWa1PpGnxmGdgnBmV8NxUnWpC 9U5Q35/Zc5FyAnVmsiebLZt9eWZOUtUvlCRg5i+a7cqPx0d5v0YymuhPW420fwjDmF8B 9abGExwIQWpSfTig+3LunhBal+mOdAghSjPDSvW4TGthnn3V9MTLz7Qxaky97N44py+3 GgIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3Z9QCuBnaG3V0M5rfTL5FcVGUPaAvk8s7UrMizywBSc=; b=XR5u53Rtqx7PHCsYi4LinOYjm1/MxxbJYUutOfPvDlu1dvyHWS1Qj9T+jrN+dXpz2s 0quduNVtAbQQcmuMekuvL2EV4O8qyE4NPOwpZ43mB2upqYUDBNgjCAMn/QazkM+qtsSu C9VQS5QNAsQRkyDfRl6TSiGGp/jDqNKjhQA8x1zVCPGLMzaSOKCdMbtt2Ljt2xtnn0N9 RSYte64vv98N3MK6ixjOpf0YGo2QXDqODPUpmfgAfYokUcRG/BKxemjzY3gspf6WaugO FfsjiYQBuivFUG/fihWOT+nViVsJpvn47+qjLgxO8KVOX1TqBxH2B+3JulpjzoAz34RV dTlA== X-Gm-Message-State: AOAM530R7CLPysIQWDxDgwkZCEUGzi2zD24DaTrcf2lAXqk5ElSCoOPZ ZolR6jKngVdpXO9zdIlnbW3y6WpFbfXyuoh9jA== X-Google-Smtp-Source: ABdhPJx5mwQn3GQlblVQmzlSty4I9Q29JE+MKg6WlAneyi2KORZr/2M0D20waUTodpFA2Sv8dVP5DRk0rjMzyv27Ssc= X-Received: by 2002:a37:b404:: with SMTP id d4mr15218565qkf.465.1623658118088; Mon, 14 Jun 2021 01:08:38 -0700 (PDT) MIME-Version: 1.0 References: <20210609135537.1460244-1-joamaki@gmail.com> <20210609135537.1460244-4-joamaki@gmail.com> <20210609220713.GA14929@ranger.igk.intel.com> In-Reply-To: <20210609220713.GA14929@ranger.igk.intel.com> From: Jussi Maki Date: Mon, 14 Jun 2021 10:08:27 +0200 Message-ID: Subject: Re: [PATCH bpf-next 3/3] selftests/bpf: Add tests for XDP bonding To: Maciej Fijalkowski Cc: bpf , netdev@vger.kernel.org, Daniel Borkmann , j.vosburgh@gmail.com, Andy Gospodarek , vfalico@gmail.com, andrii@kernel.org, magnus.karlsson@intel.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jun 10, 2021 at 12:19 AM Maciej Fijalkowski wrote: > > On Wed, Jun 09, 2021 at 01:55:37PM +0000, Jussi Maki wrote: > > Add a test suite to test XDP bonding implementation > > over a pair of veth devices. > > Cc: Magnus > > Jussi, > AF_XDP selftests have very similar functionality just like you are trying > to introduce over here, e.g. we setup veth pair and generate traffic. > After a quick look seems that we could have a generic layer that would > be used by both AF_XDP and bonding selftests. > > WDYT? Sounds like a good idea to me to have more shared code in the selftests and I don't see a reason not to use the AF_XDP datapath in the bonding selftests. I'll look into it this week and get back to you.