Re: [net-next PATCH v7 08/16] net: mdiobus: Introduce fwnode_mdiobus_register_phy()

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Calvin Johnson <calvin.johnson@oss.nxp.com>
Cc: Grant Likely <grant.likely@arm.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Cristi Sovaiala <cristian.sovaiala@nxp.com>,
	Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Madalin Bucur <madalin.bucur@oss.nxp.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Marcin Wojtas <mw@semihalf.com>,
	Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>,
	Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	Diana Madalina Craciun <diana.craciun@nxp.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux.cj" <linux.cj@gmail.com>, netdev <netdev@vger.kernel.org>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	"David S. Miller" <davem@davemloft.net>,
	Frank Rowand <frowand.list@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>
Subject: Re: [net-next PATCH v7 08/16] net: mdiobus: Introduce fwnode_mdiobus_register_phy()
Date: Thu, 11 Mar 2021 20:14:44 +0200	[thread overview]
Message-ID: <CAHp75VccA=dM8XRe1_ZS28mZ0Ehy_W-yg4_19VOH3KF=+hBu7g@mail.gmail.com> (raw)
In-Reply-To: <20210311180010.GC5031@lsv03152.swis.in-blr01.nxp.com>

On Thu, Mar 11, 2021 at 8:00 PM Calvin Johnson
<calvin.johnson@oss.nxp.com> wrote:
> On Thu, Mar 11, 2021 at 02:09:37PM +0200, Andy Shevchenko wrote:
> > On Thu, Mar 11, 2021 at 8:21 AM Calvin Johnson
> > <calvin.johnson@oss.nxp.com> wrote:

...

> > > +config FWNODE_MDIO
> > > +       def_tristate PHYLIB
> >
> > (Seems "selectable only" item)
>
> What do you mean by "selectable only" item here? Can you please point to some
> other example?

The Kconfig sections without descriptions are not user-visible.
No user can run menuconfig and check a box with "I want this to be compiled".

tristate // selectable-only
tristate "bla bla bla" // user visible and selectable

> > > +       depends on ACPI
> > > +       depends on OF
> >
> > Wouldn't be better to have
> >   depends on (ACPI || OF) || COMPILE_TEST
> >
> > And honestly I don't understand it in either (AND or OR) variant. Why
> > do you need a dependency like this for fwnode API?
>
> Here, fwnode_mdiobus_register_phy() uses objects from both ACPI and OF.

APIs? Calls? What really fails if we have !ACPI and / or !OF?

> > Moreover dependencies don't work for "selectable only" items.
> >
> > > +       depends on PHYLIB
> > > +       select FIXED_PHY

--
With Best Regards,
Andy Shevchenko