From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Calvin Johnson <calvin.johnson@oss.nxp.com>
Cc: Jeremy Linton <jeremy.linton@arm.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Jon <jon@solid-run.com>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
linux.cj@gmail.com,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [net-next PATCH v3 3/5] net: phy: introduce phy_find_by_fwnode()
Date: Wed, 8 Jul 2020 22:42:04 +0300 [thread overview]
Message-ID: <CAHp75Vd05RCbuVF8rtWjZnaDxSG+X+uQ=wLWYwy_g=jFZfHGSQ@mail.gmail.com> (raw)
In-Reply-To: <20200708173435.16256-4-calvin.johnson@oss.nxp.com>
On Wed, Jul 8, 2020 at 8:35 PM Calvin Johnson
<calvin.johnson@oss.nxp.com> wrote:
>
> The PHYs on an mdiobus are probed and registered using mdiobus_register().
> Later, for connecting these PHYs to MAC, the PHYs registered on the
> mdiobus have to be referenced.
>
> For each MAC node, a property "mdio-handle" is used to reference the
> MDIO bus on which the PHYs are registered. On getting hold of the MDIO
> bus, use phy_find_by_fwnode() to get the PHY connected to the MAC.
>
> Introduce fwnode_mdio_find_bus() to find the mii_bus that corresponds
> to given mii_bus fwnode.
...
> + err = fwnode_property_read_u32(fwnode, "phy-channel", &addr);
> + if (err < 0 || addr < 0 || addr >= PHY_MAX_ADDR)
> + return NULL;
Just wondering if we can return an error pointer here (sorry if it has
been discussed already).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-08 19:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 17:34 [net-next PATCH v3 0/5] ACPI support for dpaa2 MAC driver Calvin Johnson
2020-07-08 17:34 ` [net-next PATCH v3 1/5] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson
2020-07-08 17:34 ` [net-next PATCH v3 2/5] net/fsl: store mdiobus fwnode Calvin Johnson
2020-07-08 18:55 ` Andrew Lunn
2020-07-08 19:38 ` Andy Shevchenko
2020-07-08 17:34 ` [net-next PATCH v3 3/5] net: phy: introduce phy_find_by_fwnode() Calvin Johnson
2020-07-08 18:58 ` Andrew Lunn
2020-07-08 19:42 ` Andy Shevchenko [this message]
2020-07-08 17:34 ` [net-next PATCH v3 4/5] phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson
2020-07-08 17:34 ` [net-next PATCH v3 5/5] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vd05RCbuVF8rtWjZnaDxSG+X+uQ=wLWYwy_g=jFZfHGSQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andrew@lunn.ch \
--cc=calvin.johnson@oss.nxp.com \
--cc=cristian.sovaiala@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=jon@solid-run.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).