From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C16AEC2BBCA for ; Tue, 15 Dec 2020 17:54:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E07322B3B for ; Tue, 15 Dec 2020 17:54:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730487AbgLORxh (ORCPT ); Tue, 15 Dec 2020 12:53:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729584AbgLORxS (ORCPT ); Tue, 15 Dec 2020 12:53:18 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 437E2C06179C; Tue, 15 Dec 2020 09:52:38 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id c22so299551pgg.13; Tue, 15 Dec 2020 09:52:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mkDN3OhG3zHdAnqKmxuoGLzOmpvtxuJkY47LUS1oics=; b=LvnEcb4Ed6FsrS9J7UIvbGKW9E1moNmJZl8FcXlzJm7XILWLwfsOWyR+BtEefBLXil AOrK72cRwPvj007XWHoyeuzGmGfbn04Y3zwTWDdueyCfY4dkpbePe9TrOi2C9PVUsRlY +dVUCcT0Ykx5PRrO4Y+DnMyH69mTIUa7ZYeQWOZmj0qBDykLyalroL7Sq5zQwPdac+CA mHBYuFSrjbcKKs7XuoHGfgUivqQv9ZC7JEYgSUX8kNqkQPejzyA2aJAMCEEN02NZnDuz Z0ANzdcBTVCJzGtcc28B9b2SNUjFrsg0IcA4hNKHrtPQgKIBj1Nj1aMVtJCYt9LlyoA+ 5VuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mkDN3OhG3zHdAnqKmxuoGLzOmpvtxuJkY47LUS1oics=; b=MoZj0NltX6PPm8r0vkC48Q0Sc8ep5W2lQBLa6BFXfd8jSMlQ89IpMek0qvv/sYF3oY syDRsN+OwAvyKhwvtU8dZ8v4CXXfGvDA7SdlfJS+EC1F8yoVo5fcejC3uzX2YS3m6PsY 4zrLAvEPSBXyNK00Q4fULXH+S4suMWD/qndf2bBjxI6i0lQZNiobzwwwQiqtdETq2lvg uYYfaJUso1+kBfp1X0q6f/jDt3wNBz7mkLYjzl7UQ0ERpIZBQtn+qp280+gzg8qG4Rsm 3931A8BraS2dRq4lCFkqFgXAAeo9yjPGxjfzt9A/p9Cn37GLcGxw1/8mNRvtXxLDCc8c TsUQ== X-Gm-Message-State: AOAM530kkFm0ap8Er7rfB0c4GymvtZsq24KkyG9/SlZakkth1TJrbOBc xww00dcly+BXgiWZygB2nQYVmSilOA+sTb2xoEs= X-Google-Smtp-Source: ABdhPJwIdEFUP+WJMxPu4F840DYWkR5bZ89GYBArqV8XOJl/TwcyZMgjTqBY9eF7d8NxOsFHOgKyWQHorldsdoQR9Qw= X-Received: by 2002:a63:b1e:: with SMTP id 30mr30019652pgl.203.1608054757866; Tue, 15 Dec 2020 09:52:37 -0800 (PST) MIME-Version: 1.0 References: <20201215164315.3666-1-calvin.johnson@oss.nxp.com> <20201215164315.3666-9-calvin.johnson@oss.nxp.com> In-Reply-To: <20201215164315.3666-9-calvin.johnson@oss.nxp.com> From: Andy Shevchenko Date: Tue, 15 Dec 2020 19:53:26 +0200 Message-ID: Subject: Re: [net-next PATCH v2 08/14] net: mdiobus: Introduce fwnode_mdiobus_register() To: Calvin Johnson Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , "linux.cj" , Laurentiu Tudor , Diana Madalina Craciun , ACPI Devel Maling List , Linux Kernel Mailing List , linux-arm Mailing List , netdev , "David S. Miller" , Heiner Kallweit , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson wrote: > > Introduce fwnode_mdiobus_register() to register PHYs on the mdiobus. > If the fwnode is DT node, then call of_mdiobus_register(). > If it is an ACPI node, then: > - disable auto probing of mdiobus > - register mdiobus > - save fwnode to mdio structure > - loop over child nodes & register a phy_device for each PHY ... > +/** > + * fwnode_mdiobus_register - Register mii_bus and create PHYs from fwnode > + * @mdio: pointer to mii_bus structure > + * @fwnode: pointer to fwnode of MDIO bus. > + * > + * This function registers the mii_bus structure and registers a phy_device > + * for each child node of @fwnode. > + */ > +int fwnode_mdiobus_register(struct mii_bus *mdio, struct fwnode_handle *fwnode) > +{ > + struct fwnode_handle *child; > + unsigned long long addr; > + acpi_status status; > + int ret; > + > + if (is_of_node(fwnode)) { > + return of_mdiobus_register(mdio, to_of_node(fwnode)); > + } else if (is_acpi_node(fwnode)) { I would rather see this as simple as if (is_of_node(fwnode)) return of_mdiobus_register(mdio, to_of_node(fwnode)); if (is_acpi_node(fwnode)) return acpi_mdiobus_register(mdio, fwnode); where the latter one is defined somewhere in drivers/acpi/. > + /* Mask out all PHYs from auto probing. */ > + mdio->phy_mask = ~0; > + ret = mdiobus_register(mdio); > + if (ret) > + return ret; > + > + mdio->dev.fwnode = fwnode; > + /* Loop over the child nodes and register a phy_device for each PHY */ > + fwnode_for_each_child_node(fwnode, child) { > + status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(child), > + "_ADR", NULL, &addr); > + if (ACPI_FAILURE(status)) { Isn't it fwnode_get_id() now? > + pr_debug("_ADR returned %d\n", status); > + continue; > + } > + if (addr < 0 || addr >= PHY_MAX_ADDR) > + continue; addr can't be less than 0. > + ret = fwnode_mdiobus_register_phy(mdio, child, addr); > + if (ret == -ENODEV) > + dev_err(&mdio->dev, > + "MDIO device at address %lld is missing.\n", > + addr); > + } > + return 0; > + } > + return -EINVAL; > +} -- With Best Regards, Andy Shevchenko