From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Vadym Kochan <vadym.kochan@plvision.eu>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>, Andrew Lunn <andrew@lunn.ch>,
Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
Serhiy Boiko <serhiy.boiko@plvision.eu>,
Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
Taras Chornyi <taras.chornyi@plvision.eu>,
Andrii Savka <andrii.savka@plvision.eu>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mickey Rachamim <mickeyr@marvell.com>
Subject: Re: [PATCH net-next v7 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices
Date: Thu, 10 Sep 2020 14:28:35 +0300 [thread overview]
Message-ID: <CAHp75Vf9DJZhOMcaAebtQoz_biY1kFS34W1Fp0kdDFiDm4T7vg@mail.gmail.com> (raw)
In-Reply-To: <20200910082512.GE20411@plvision.eu>
On Thu, Sep 10, 2020 at 11:25 AM Vadym Kochan <vadym.kochan@plvision.eu> wrote:
> On Fri, Sep 04, 2020 at 10:12:07PM +0300, Andy Shevchenko wrote:
> > On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan <vadym.kochan@plvision.eu> wrote:
> > > + .param = {.admin_state = admin_state}
> >
> > + white spaces? Whatever you choose, just be consistent among all
> > similar definitions.
> >
>
> Can I use following format for one-liner embedded struct ?
Of course. It's just a style matter.
My point that you need to be consistent over all similar cases in the code.
> .param = {
> .admin_state = admin_state,
> }
> > ...
> >
>
> I think it looks better when all of the members filled looks similar
> (even if it requires 2 additional lines) instead of having:
>
> .member = { E } ?
I like the former one (as you do), but in some cases when you have one
member or an array it's convenient to have them one one line.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-10 11:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 16:52 [PATCH net-next v7 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX3255 (AC3x) Vadym Kochan
2020-09-04 16:52 ` [PATCH net-next v7 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices Vadym Kochan
2020-09-04 19:12 ` Andy Shevchenko
2020-09-07 7:30 ` Vadym Kochan
2020-09-07 7:55 ` Andy Shevchenko
2020-09-09 14:17 ` Vadym Kochan
2020-09-08 8:35 ` Vadym Kochan
2020-09-08 9:38 ` Andy Shevchenko
2020-09-09 14:00 ` Vadym Kochan
2020-09-09 14:09 ` Andy Shevchenko
2020-09-10 8:25 ` Vadym Kochan
2020-09-10 11:28 ` Andy Shevchenko [this message]
2020-09-04 16:52 ` [PATCH net-next v7 2/6] net: marvell: prestera: Add PCI interface support Vadym Kochan
2020-09-04 19:25 ` Andy Shevchenko
2020-09-04 16:52 ` [PATCH net-next v7 3/6] net: marvell: prestera: Add basic devlink support Vadym Kochan
2020-09-04 16:52 ` [PATCH net-next v7 4/6] net: marvell: prestera: Add ethtool interface support Vadym Kochan
2020-09-04 19:38 ` Andy Shevchenko
2020-09-04 16:52 ` [PATCH net-next v7 5/6] net: marvell: prestera: Add Switchdev driver implementation Vadym Kochan
2020-09-04 19:41 ` Andy Shevchenko
2020-09-10 7:03 ` Vadym Kochan
2020-09-04 16:52 ` [PATCH net-next v7 6/6] dt-bindings: marvell,prestera: Add description for device-tree bindings Vadym Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf9DJZhOMcaAebtQoz_biY1kFS34W1Fp0kdDFiDm4T7vg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andrew@lunn.ch \
--cc=andrii.savka@plvision.eu \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
--cc=serhiy.boiko@plvision.eu \
--cc=serhiy.pshyk@plvision.eu \
--cc=taras.chornyi@plvision.eu \
--cc=vadym.kochan@plvision.eu \
--cc=volodymyr.mytnyk@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).