From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14F9C11F67 for ; Tue, 13 Jul 2021 12:46:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF975611AB for ; Tue, 13 Jul 2021 12:46:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236351AbhGMMtV (ORCPT ); Tue, 13 Jul 2021 08:49:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236276AbhGMMtU (ORCPT ); Tue, 13 Jul 2021 08:49:20 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B67F3C0613DD; Tue, 13 Jul 2021 05:46:30 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id 62so21550604pgf.1; Tue, 13 Jul 2021 05:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OSSm6vgQ/hSSbGft4asv3z9r3hlk04ITp8gGHFuDvJw=; b=O39QOghdBj2CErHDzCypebVvNfoixfpYts0+Kds4Ts4zA0Yh+shjkOTnx0g2yp7mIN gAW8vorFQtxLHvSPiqQVLIkfYfS3J32Rm/7zqaNd3W8YexLbuAKA0/1QuRfWMKFYyekv VPxl06BGV7KvPuaeq5qqPAKPFkE1xCRYPzl/Fi0z3kYLdS3aY41tN6AeaytCgX8CLlHc +VxTbEErb/axjLe8hMOsnQmzkYTCj3RFBaT7XVFqGs2WMXbcpFQYY/ts89D2GtvhMK7w E7311D/UuhrIXxgOoWXK4ytFyOoT0GBJVzpa1dUZXtw+emVEKXFBz1+3XdwOASmtsso5 5r8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OSSm6vgQ/hSSbGft4asv3z9r3hlk04ITp8gGHFuDvJw=; b=ZhI/4/Lbd15yIdE6ntWlGwqDdlJ7tT5hWDPYS3VgB/pFtGviZxjmiaYwdDqFFdVnMl K2WiqXEfkQA7j8/wYa7+1AuDjj1CmoE268n+DWG7d5gISnS8D+jP0RjIgEuHpwRZvrEP tD9k1g3p9VnTsSuNNrzVTyq4SSc8etptjx8mLuKP1zQXdhBPucASkPbeooTxXY6rcaZ9 Lp/Pc3E8LXWtca+5XpVsv1BR+vbODY2FwLLd46Kd8PbEv29hm5LsLuS+GbuEfkwTTbpY 1u9bQKWjUsy6jZXZMSTdabBrpDWIpqPQc+XJdc4XNigSpDKHtce316uUKU+W+ua118zJ K7Tw== X-Gm-Message-State: AOAM532fWKQ4hd71NKc+IbBglCxgHb41LHH/t4+LJP5R/QF6FAYdIVhV OxEQjAPTHNhQqj5t4Sf+c80mnsog1krinu0ZxiU= X-Google-Smtp-Source: ABdhPJx/eA7qttUtbxpBlfH2rmDd3YHt9oPD7s1U8eIfqlDXzmWYLqbH+5Zu/3++zSAoGtFtVxI3MqkvwM4efGpLntE= X-Received: by 2002:aa7:8055:0:b029:303:36a6:fec7 with SMTP id y21-20020aa780550000b029030336a6fec7mr4670949pfm.40.1626180390255; Tue, 13 Jul 2021 05:46:30 -0700 (PDT) MIME-Version: 1.0 References: <20210713084541.7958-1-andriy.shevchenko@linux.intel.com> <20210713084541.7958-3-andriy.shevchenko@linux.intel.com> <20210713121944.GA24157@gondor.apana.org.au> In-Reply-To: <20210713121944.GA24157@gondor.apana.org.au> From: Andy Shevchenko Date: Tue, 13 Jul 2021 15:45:51 +0300 Message-ID: Subject: Re: [PATCH v1 3/3] kernel.h: Split out container_of() and typeof_memeber() macros To: Herbert Xu Cc: Greg Kroah-Hartman , Andy Shevchenko , Brendan Higgins , Peter Zijlstra , Alexey Dobriyan , Miguel Ojeda , Mauro Carvalho Chehab , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Media Mailing List , netdev , bpf , "Rafael J. Wysocki" , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Steven Rostedt , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Thomas Graf , Andrew Morton , Jonathan Cameron , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 13, 2021 at 3:21 PM Herbert Xu wrote: > On Tue, Jul 13, 2021 at 01:23:01PM +0200, Greg Kroah-Hartman wrote: > > > > Life is messy and can not easily be partitioned into tiny pieces. That > > way usually ends up being even messier in the end... > > One advantage is less chance of header loops which very often > involve kernel.h and one of the most common reasons for other > header files to include kernel.h is to access container_of. Thanks, yes, that's also one important point. > However, I don't see much point in touching *.c files that include > kernel.h. The whole idea came when discussing drivers, esp. IIO ones. They often are using ARRAY_SIZE() + container_of(). kernel.h is a big overkill there. -- With Best Regards, Andy Shevchenko