From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80662C48BE5 for ; Tue, 15 Jun 2021 19:51:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C88A61246 for ; Tue, 15 Jun 2021 19:51:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230377AbhFOTxG (ORCPT ); Tue, 15 Jun 2021 15:53:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbhFOTxF (ORCPT ); Tue, 15 Jun 2021 15:53:05 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FDC1C061574; Tue, 15 Jun 2021 12:51:00 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id u18so256424pfk.11; Tue, 15 Jun 2021 12:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Tmn7Qs27sSC17wg+6pi/G56sByOCg1rr24W9UoH5oRo=; b=AEW3YvA+PHWywV7H/jrnAFE/mjA14AFvBLdSP2YYo+4IbWudhW3aVLiFuXdZ/Frdj1 3PNNkpRk4v05vttaidUgqZQ416Q+ePKHPQfyyyAijo5H1PCUkvHom1N24AMHax47oc+R sZrNibho2qVqps++bIFyYuv4a6gkp5KyJyycLpOfXi93MQLfNU8zpstODqfLIwvnNvfp ygl+8PnDM1/3/heskVFoNqS7Q35oGRLbMFlxCDWk99Xss+6H3n8hSHpDCfJPj4S/tjVA 3UyDAhVwZmm129op8ErQJOTPadoEvQDETHuHcjs8zUmBDTaUnbXC1bbELL/v5FwkBVvy UO1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Tmn7Qs27sSC17wg+6pi/G56sByOCg1rr24W9UoH5oRo=; b=QFyqPiow3S9Ikzr0RRWgcl3QhXf5uy3pE88v32709dDEHNxJAs0Ie6XYr/ymiY+ijT kp9HYUVDcUGUUvIG2UgIkYMcF9F7VNb9T6SrLev2StdeJnmTP8UG+ki40vcPTcTPEmrb h3WBv16s4KFgnR4As0kxMDVocxvdFBXHXEeqIBH8+ZkHeml102UvbOE6vefyfjXHVNej yMGt1EC/AKciGKk/GItfDZHtoLqSggeZ4kCdBnPFbV+yKICw9KNUe+DNsX1Rq7uxIVba tXP/WhMEwu9kLfhllxC8obR73dUUQ/ICNcziTngoiQYCF5KallPGIbgzlAU6SPnSO1A3 9RsQ== X-Gm-Message-State: AOAM5316NItXf3UcoGp+CwJKKagvl4oZP2K0o1drss9Y4H0XRhPcOZTB JNV9U1pvoI3BB8EELMldDVYLqeuSIYanlug4LKR/bAv3WuoVKo8j X-Google-Smtp-Source: ABdhPJyaFJ17QXCrI4dW/f6IRBXohJ1AwMqYeFCfuAe7mj1IAIfIYLVGSnzcTEuIG2mMv/Hlh2ci/uEIyNxxFEX+CB8= X-Received: by 2002:a05:6a00:139c:b029:2f7:102c:5393 with SMTP id t28-20020a056a00139cb02902f7102c5393mr6179944pfg.40.1623786659779; Tue, 15 Jun 2021 12:50:59 -0700 (PDT) MIME-Version: 1.0 References: <20210613183520.2247415-1-mw@semihalf.com> <20210613183520.2247415-2-mw@semihalf.com> In-Reply-To: From: Andy Shevchenko Date: Tue, 15 Jun 2021 22:50:43 +0300 Message-ID: Subject: Re: [net-next: PATCH 1/3] net: mvmdio: add ACPI support To: Marcin Wojtas Cc: Andrew Lunn , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "davem@davemloft.net" , "kuba@kernel.org" , "linux@armlinux.org.uk" , "jaz@semihalf.com" , "gjb@semihalf.com" , "upstream@semihalf.com" , "Samer.El-Haj-Mahmoud@arm.com" , "jon@solid-run.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jun 15, 2021 at 6:09 PM Marcin Wojtas wrote: > niedz., 13 cze 2021 o 22:08 Andy Shevchenko > napisa=C5=82(a): > > On Sunday, June 13, 2021, Andrew Lunn wrote: > > The better approach is to switch to devm_get_clk_optional() as I have d= one in several drivers, IIRC recently in mvpp2 > > > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/com= mit/?id=3Dcf3399b731d36bc780803ff63e4d480a1efa33ac > > Yes, this would be a nice improvement, however the > devm_get_clk_optional requires clock name (type char *) - mvmdio uses > raw indexes, so this helper unfortunately seems to be not applicable. As far as I can read the code it smells like devm_clk_bulk_get_optional(). Am I mistaken? --=20 With Best Regards, Andy Shevchenko