From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM Date: Fri, 30 Oct 2015 15:34:09 +0200 Message-ID: References: <20151029233430.GB11420@oracle.com> <20151030112637.GB9312@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: intel-wired-lan@lists.osuosl.org, netdev , "linux-kernel@vger.kernel.org" , jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com, shannon.nelson@intel.com, carolyn.wyborny@intel.com, donald.c.skidmore@intel.com, matthew.vick@intel.com, john.ronciak@intel.com, mitch.a.williams@intel.com, martin.petersen@oracle.com To: Sowmini Varadhan Return-path: In-Reply-To: <20151030112637.GB9312@oracle.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Oct 30, 2015 at 1:26 PM, Sowmini Varadhan wrote: > On (10/30/15 02:14), Andy Shevchenko wrote: >> >> Does the following has no stubs? >> >> > + struct i40e_pf *pf = hw->back; >> > + struct device_node *dp = pci_device_to_OF_node(pf->pdev); >> > + const unsigned char *addr; >> > + >> > + addr = of_get_mac_address(dp); >> >> ^^^ > > I was not able to find any. > I'm fixing up the rest and respinning V2 as a separate thread. of_net.h contains the stub of of_get_mac_addr() which means you don't need to put ugly ifdefs in the function. Have no idea about CONFIG_SPARC though. -- With Best Regards, Andy Shevchenko