Re: [PATCH bpf-next] selftests/bpf: add lwt ip encap tests to test_progs

From: Eyal Birger <eyal.birger@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>, andrii@kernel.org
Cc: shuah@kernel.org, ast@kernel.org, kafai@fb.com,
	songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
	kpsingh@kernel.org, posk@google.com,
	linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: add lwt ip encap tests to test_progs
Date: Tue, 14 Jun 2022 19:59:24 +0300	[thread overview]
Message-ID: <CAHsH6GvWkyDg5mXnSNoyY0H2V2i4iMsucydB=RZB100czc-85A@mail.gmail.com> (raw)
In-Reply-To: <f80edf4f-c795-1e1e-bac2-414189988156@iogearbox.net>

On Fri, Jun 10, 2022 at 12:37 AM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> Hi Eyal,
>
> On 6/7/22 3:31 PM, Eyal Birger wrote:
> > Port test_lwt_ip_encap.sh tests onto test_progs.
> >
> > In addition, this commit adds "egress_md" tests which test a similar
> > flow as egress tests only they use gre devices in collect_md mode
> > for encapsulation and set the tunnel key using bpf_set_tunnel_key().
> >
> > This introduces minor changes to test_lwt_ip_encap.{sh,c} for consistency
> > with the new tests:
> >
> > - GRE key must exist as bpf_set_tunnel_key() explicitly sets the
> >    TUNNEL_KEY flag
> >
> > - Source address for GRE traffic is set to IP*_5 instead of IP*_1 since
> >    GRE traffic is sent via veth5 so its address is selected when using
> >    bpf_set_tunnel_key()
> >
> > Note: currently these programs use the legacy section name convention
> > as iproute2 lwt configuration does not support providing function names.
> >
> > Signed-off-by: Eyal Birger <eyal.birger@gmail.com>
> > ---
> >   .../selftests/bpf/prog_tests/lwt_ip_encap.c   | 582 ++++++++++++++++++
> >   .../selftests/bpf/progs/test_lwt_ip_encap.c   |  51 +-
> >   .../selftests/bpf/test_lwt_ip_encap.sh        |   6 +-
> >   3 files changed, 633 insertions(+), 6 deletions(-)
> >   create mode 100644 tools/testing/selftests/bpf/prog_tests/lwt_ip_encap.c
> >
> > diff --git a/tools/testing/selftests/bpf/prog_tests/lwt_ip_encap.c b/tools/testing/selftests/bpf/prog_tests/lwt_ip_encap.c
> > new file mode 100644
> > index 000000000000..e1b6f3ce6045
> > --- /dev/null
> > +++ b/tools/testing/selftests/bpf/prog_tests/lwt_ip_encap.c
> > @@ -0,0 +1,582 @@
> [...]
>
> Thanks a lot for porting the test into test_progs! Looks like the BPF CI currently
> bails out here:
>
> https://github.com/kernel-patches/bpf/runs/6812283921?check_suite_focus=true
>
> Andrii, looks like we might be missing CONFIG_NET_VRF in vmtest config-latest.*?

Hi Andrii,

What's the next step - should I submit a PR to libbpf on Github for adding
CONFIG_NET_VRF?

Eyal.