From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C2C4C4CED1 for ; Thu, 3 Oct 2019 10:50:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 744972086A for ; Thu, 3 Oct 2019 10:50:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yw6zyNoU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729445AbfJCKug (ORCPT ); Thu, 3 Oct 2019 06:50:36 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:43271 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728234AbfJCKuf (ORCPT ); Thu, 3 Oct 2019 06:50:35 -0400 Received: by mail-qk1-f194.google.com with SMTP id h126so1817556qke.10; Thu, 03 Oct 2019 03:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fM8THgk9XJ8sEx3BQtTeX7NMdju8tZeZ21w0FheC/X8=; b=Yw6zyNoUH4yW7RQ7YV/7pJcwMNXfuTZin2s/vuqWslxOAE4epDnrWzWgpUbLtI8hDA HCVll6Yh+odiUiVVb7MEZ3qz32civ6+r1+Gee42f5hA465jar5eE+/Mx7qBDkRqB+t2W wW3T3dz1ZFePY825jVVGxLvhovVOPOVkY5L+bBeZHxnvamkRVuY3FBFoDnAlwfvjmthq wC7a7z0hq2/ZAw6DPVtwNxkC0U70C3ONCDKKO0w3BEY8obTeZDHuBVn03N5z2xV4VoUj 49WeCaq1NNaGCUPphU+k1YwfEfnO79wk8kehNyTcVzvlgQ8hJ21EgwFir6+qlsAC6fES sT1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fM8THgk9XJ8sEx3BQtTeX7NMdju8tZeZ21w0FheC/X8=; b=PuWc8KJFNlnAylrkY7giVxKUS9QaH+Pjym19IWAKxjl7pKt24XhKerAapCuBhDKelO InUQk/HP07fyTwNHS9vwgqArCvbh8xsfrYEuKrSbfb/4cetFyA6di5tcMkkgvdXA9FG9 +Ia/sJNDCn+Cmn/fnnF5/YuFbonDP7ToHVdAd4BqyLf/XcDBoxxfZ89fgVkxs6Qm8bKT PVoB1DTYyxOGbnOKJ8yw8CaKkdjunAiezWq4mFYw1PtZ3UR+mqSbAPK2Eml6sXksvw5k Uzfy5yffY7OjlpG4eOdrgEbWJo2pNtzdBypQcA8FUgwwxIlmw5xX5k/1rORlPPurzoS9 Beyw== X-Gm-Message-State: APjAAAV3egMP+FyFruq03V8ZccCVbwSR0EgQmWO+S3/E3gmvjxMQ/Gm2 M0yov9q7LvZQSO6H5ZZRxLBSuCkxBet9vSIlmMY= X-Google-Smtp-Source: APXvYqyy5HXJM2u1U8CaDWPNkgh8DjaBowL+QJagMg52IaLV/RQvEkR4ypi9bc/ESi24zGBP49W6itIZ24w1nDkJSGg= X-Received: by 2002:a37:4b02:: with SMTP id y2mr3537894qka.493.1570099834447; Thu, 03 Oct 2019 03:50:34 -0700 (PDT) MIME-Version: 1.0 References: <20191001101429.24965-1-bjorn.topel@gmail.com> <20191002231448.GA10649@khorivan> In-Reply-To: From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Date: Thu, 3 Oct 2019 12:50:23 +0200 Message-ID: Subject: Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig To: Masahiro Yamada Cc: Ivan Khoronzhuk , Networking , Alexei Starovoitov , Daniel Borkmann , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Linux Kbuild mailing list , bpf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 3 Oct 2019 at 12:37, Masahiro Yamada wrote: > > On Thu, Oct 3, 2019 at 3:28 PM Bj=C3=B6rn T=C3=B6pel wrote: > > > > On Thu, 3 Oct 2019 at 01:14, Ivan Khoronzhuk wrote: > > > > > > On Wed, Oct 02, 2019 at 09:41:15AM +0200, Bj=C3=B6rn T=C3=B6pel wrote= : > > > >On Wed, 2 Oct 2019 at 03:49, Masahiro Yamada > > > > wrote: > > > >> > > > >[...] > > > >> > Yes, the BPF samples require clang/LLVM with BPF support to buil= d. Any > > > >> > suggestion on a good way to address this (missing tools), better= than > > > >> > the warning above? After the commit 394053f4a4b3 ("kbuild: make = single > > > >> > targets work more correctly"), it's no longer possible to build > > > >> > samples/bpf without support in the samples/Makefile. > > > >> > > > >> > > > >> You can with > > > >> > > > >> "make M=3Dsamples/bpf" > > > >> > > > > > > > >Oh, I didn't know that. Does M=3D support "output" builds (O=3D)? > > No. > O=3D points to the output directory of vmlinux, > not of the external module. > > You cannot put the build artifacts from samples/bpf/ > in a separate directory. > Hmm, I can't even get "make M=3Dsamples/bpf/" to build. Am I missing something obvious? Prior 394053f4a4b3 "make samples/bpf/" and "make O=3D/foo/bar samples/bpf/" worked, but I guess I can live with that... Thanks! Bj=C3=B6rn > > > > > >I usually just build samples/bpf/ with: > > > > > > > > $ make V=3D1 O=3D/home/foo/build/bleh samples/bpf/ > > > > > > > > > > > >Bj=C3=B6rn > > > > > > Shouldn't README be updated? > > > > > > > Hmm, the M=3D variant doesn't work at all for me. The build is still > > broken for me. Maybe I'm missing anything obvious... > > > > > > > -- > > > Regards, > > > Ivan Khoronzhuk > > > > -- > Best Regards > Masahiro Yamada