netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Björn Töpel" <bjorn.topel@gmail.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
	Netdev <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [net PATCH] ixgbe: Fix NULL pointer dereference in ethtool loopback test
Date: Tue, 9 Mar 2021 08:29:55 +0100	[thread overview]
Message-ID: <CAJ+HfNiDZ+iw50W-N9KprHDygzMZcrTteX1KVpmXC0dafDi-RA@mail.gmail.com> (raw)
In-Reply-To: <161523611656.36376.3641992659589167121.stgit@localhost.localdomain>

On Mon, 8 Mar 2021 at 21:42, Alexander Duyck <alexander.duyck@gmail.com> wrote:
>
> From: Alexander Duyck <alexanderduyck@fb.com>
>
> The ixgbe driver currently generates a NULL pointer dereference when
> performing the ethtool loopback test. This is due to the fact that there
> isn't a q_vector associated with the test ring when it is setup as
> interrupts are not normally added to the test rings.
>
> To address this I have added code that will check for a q_vector before
> returning a napi_id value. If a q_vector is not present it will return a
> value of 0.
>
> Fixes: b02e5a0ebb17 ("xsk: Propagate napi_id to XDP socket Rx path")
> Signed-off-by: Alexander Duyck <alexanderduyck@fb.com>

Thanks Alex!

Acked-by: Björn Töpel <bjorn.topel@intel.com>

I'll look into if this applies to the other Intel drivers as well.


Björn
[...]

  reply	other threads:[~2021-03-09  7:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 20:41 [net PATCH] ixgbe: Fix NULL pointer dereference in ethtool loopback test Alexander Duyck
2021-03-09  7:29 ` Björn Töpel [this message]
2021-04-09 19:39 ` Switzer, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ+HfNiDZ+iw50W-N9KprHDygzMZcrTteX1KVpmXC0dafDi-RA@mail.gmail.com \
    --to=bjorn.topel@gmail.com \
    --cc=alexander.duyck@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).