From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@gmail.com>
Subject: Re: [RFC PATCH 2/3] riscv: add build infra for JIT compiler
Date: Tue, 15 Jan 2019 17:09:53 +0100
Message-ID: <CAJ+HfNiP=cBhHurxxcpbUyt9BZyV1uHaLfHD-89N-rAkAbjr-g@mail.gmail.com>
References: <20190115083518.10149-1-bjorn.topel@gmail.com> <20190115083518.10149-3-bjorn.topel@gmail.com>
 <20190115154327.GH26443@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: linux-riscv@lists.infradead.org,
        Palmer Dabbelt <palmer@sifive.com>, davidlee@sifive.com,
        Daniel Borkmann <daniel@iogearbox.net>,
        Netdev <netdev@vger.kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qt1-f194.google.com ([209.85.160.194]:35671 "EHLO
        mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728498AbfAOQKG (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 15 Jan 2019 11:10:06 -0500
Received: by mail-qt1-f194.google.com with SMTP id v11so3563969qtc.2
        for <netdev@vger.kernel.org>; Tue, 15 Jan 2019 08:10:05 -0800 (PST)
In-Reply-To: <20190115154327.GH26443@infradead.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Den tis 15 jan. 2019 kl 16:43 skrev Christoph Hellwig <hch@infradead.org>:
>
> >  core-y +=3D arch/riscv/kernel/ arch/riscv/mm/
> >
> > +ifeq ($(CONFIG_ARCH_RV64I),y)
> > +core-y +=3D arch/riscv/net/
> > +endif
>
> I think this should be core-$(CONFIG_ARCH_RV64I) to get the same result.
> Or even better just core-y given that the Kconfig dependencies should
> ensure you can't ever enable CONFIG_BPF_JIT for 32-bit builds.
>

Good point! I'll address that!

> > new file mode 100644
> > index 000000000000..b0b6ac13edf5
> > --- /dev/null
> > +++ b/arch/riscv/net/Makefile
> > @@ -0,0 +1,5 @@
> > +#
> > +# RISCV networking code
> > +#
>
> I don't think this comment adds any value.  In fact it is highly
> confusing given that we use bpf for a lot more than networking these
> days.
>

Yeah, I agree. I'll remove that.

> > diff --git a/arch/riscv/net/bpf_jit_comp.c b/arch/riscv/net/bpf_jit_com=
p.c
> > new file mode 100644
> > index 000000000000..7e359d3249ee
> > --- /dev/null
> > +++ b/arch/riscv/net/bpf_jit_comp.c
> > @@ -0,0 +1,4 @@
> > +struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog)
> > +{
> > +     return prog;
> > +}
>
> Please don't just add stubs files.  This patch should probably be merged
> into the one adding the actual implementation.

Noted! I'll remove that!

Thanks for taking a look, Christoph!


Bj=C3=B6rn