Re: [PATCH bpf-next 0/6] Enhancements to xdpsock application

From: "Björn Töpel" <bjorn.topel@gmail.com>
To: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
Cc: "Karlsson, Magnus" <magnus.karlsson@intel.com>,
	"Björn Töpel" <bjorn.topel@intel.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	Netdev <netdev@vger.kernel.org>,
	"Jonathan Lemon" <jonathan.lemon@gmail.com>,
	bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next 0/6] Enhancements to xdpsock application
Date: Fri, 20 Dec 2019 11:04:42 +0100	[thread overview]
Message-ID: <CAJ+HfNjAC-hFdW14yCDSkBUZVmRM=ya+GFyWV5AOYAi8=KBV6w@mail.gmail.com> (raw)
In-Reply-To: <20191220085530.4980-1-jay.jayatheerthan@intel.com>

On Fri, 20 Dec 2019 at 09:55, Jay Jayatheerthan
<jay.jayatheerthan@intel.com> wrote:
>
> This series of patches enhances xdpsock application with command line
> parameters to set transmit packet size and fill pattern among other options.
> The application has also been enhanced to use Linux Ethernet/IP/UDP header
> structs and calculate IP and UDP checksums.
>
> I have measured the performance of the xdpsock application before and after
> this patch set and have not been able to detect any difference.
>
> Packet Size:
> ------------
> There is a new option '-s' or '--tx-pkt-size' to specify the transmit packet
> size. It ranges from 47 to 4096 bytes. Default packet size is 64 bytes
> which is same as before.
>
> Fill Pattern:
> -------------
> The transmit UDP payload fill pattern is specified using '-P' or
> '--tx-pkt-pattern'option. It is an unsigned 32 bit field and defaulted
> to 0x12345678.
>
> Packet Count:
> -------------
> The number of packets to send is specified using '-C' or '--tx-pkt-count'
> option. If it is not specified, the application sends packets forever.
>
> Batch Size:
> -----------
> The batch size for transmit, receive and l2fwd features of the application is
> specified using '-b' or '--batch-size' options. Default value when this option
> is not provided is 64 (same as before).
>
> Duration:
> ---------
> The application supports '-d' or '--duration' option to specify number of
> seconds to run. This is used in tx, rx and l2fwd features. If this option is
> not provided, the application runs for ever.
>
> This patchset has been applied against commit 99cacdc6f661f50f
> ("Merge branch 'replace-cg_bpf-prog'")
>

Thanks for the hard work! I really like the synchronous cleanup! My
scripts are already using the '-d' flag!

For the series:
Tested-by: Björn Töpel <bjorn.topel@intel.com>
Acked-by: Björn Töpel <bjorn.topel@intel.com>

> Jay Jayatheerthan (6):
>   samples/bpf: xdpsock: Add duration option to specify how long to run
>   samples/bpf: xdpsock: Use common code to handle signal and main exit
>   samples/bpf: xdpsock: Add option to specify batch size
>   samples/bpf: xdpsock: Add option to specify number of packets to send
>   samples/bpf: xdpsock: Add option to specify tx packet size
>   samples/bpf: xdpsock: Add option to specify transmit fill pattern
>
>  samples/bpf/xdpsock_user.c | 426 +++++++++++++++++++++++++++++++++----
>  1 file changed, 387 insertions(+), 39 deletions(-)
>
> --
> 2.17.1
>