From: "Björn Töpel" <bjorn.topel@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: "Karlsson, Magnus" <magnus.karlsson@intel.com>,
"Duyck, Alexander H" <alexander.h.duyck@intel.com>,
"Alexander Duyck" <alexander.duyck@gmail.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Alexei Starovoitov" <ast@fb.com>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Netdev <netdev@vger.kernel.org>,
"Björn Töpel" <bjorn.topel@intel.com>,
michael.lundkvist@ericsson.com, "Brandeburg,
Jesse" <jesse.brandeburg@intel.com>,
"Singhai, Anjali" <anjali.singhai@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [PATCH bpf-next v3 06/15] xsk: add Rx receive functions and poll support
Date: Tue, 22 May 2018 09:42:15 +0200 [thread overview]
Message-ID: <CAJ+HfNjrqbMHRoA7-Zc4xEvDxpbqcRFcMYXkOF2Ns6UdGD9osQ@mail.gmail.com> (raw)
In-Reply-To: <3fef2b46-1ba0-c91c-d5a9-0aec51957237@iogearbox.net>
2018-05-04 14:59 GMT+02:00 Daniel Borkmann <daniel@iogearbox.net>:
[...]
>> +
>> +int xsk_rcv(struct xdp_sock *xs, struct xdp_buff *xdp)
>> +{
>> + int err;
>> +
>> + err = __xsk_rcv(xs, xdp);
>> + if (likely(!err))
>> + xdp_return_buff(xdp);
>> + else
>> + xs->rx_dropped++;
>
> This is triggered from __bpf_tx_xdp_map() -> __xsk_map_redirect().
> Should this be percpu counter instead?
>
No, it shouldn't be percpu, but the drop count shouldn't be increased
here. It should be increased as a result of full queue event. Thanks
for pointing this out, I'll fix it.
Björn
[...]
next prev parent reply other threads:[~2018-05-22 7:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 11:01 [PATCH bpf-next v3 00/15] Introducing AF_XDP support Björn Töpel
2018-05-02 11:01 ` [PATCH bpf-next v3 01/15] net: initial AF_XDP skeleton Björn Töpel
2018-05-23 22:50 ` Stephen Hemminger
2018-05-24 6:38 ` Björn Töpel
2018-05-24 17:57 ` Alexei Starovoitov
2018-05-02 11:01 ` [PATCH bpf-next v3 02/15] xsk: add user memory registration support sockopt Björn Töpel
2018-05-04 12:34 ` Daniel Borkmann
2018-05-02 11:01 ` [PATCH bpf-next v3 03/15] xsk: add umem fill queue support and mmap Björn Töpel
2018-05-04 12:49 ` Daniel Borkmann
2018-05-02 11:01 ` [PATCH bpf-next v3 04/15] xsk: add Rx queue setup and mmap support Björn Töpel
2018-05-02 11:01 ` [PATCH bpf-next v3 05/15] xsk: add support for bind for Rx Björn Töpel
2018-05-02 11:01 ` [PATCH bpf-next v3 06/15] xsk: add Rx receive functions and poll support Björn Töpel
2018-05-04 12:59 ` Daniel Borkmann
2018-05-22 7:42 ` Björn Töpel [this message]
2018-05-02 11:01 ` [PATCH bpf-next v3 07/15] bpf: introduce new bpf AF_XDP map type BPF_MAP_TYPE_XSKMAP Björn Töpel
2018-10-08 15:31 ` Eric Dumazet
2018-10-08 16:05 ` Björn Töpel
2018-10-08 16:52 ` Björn Töpel
2018-10-08 16:55 ` Eric Dumazet
2018-10-08 17:04 ` Björn Töpel
2018-10-08 17:40 ` [PATCH bpf] xsk: do not call synchronize_net() under RCU read lock Björn Töpel
2018-10-09 0:30 ` Song Liu
2018-10-11 8:22 ` Daniel Borkmann
2018-05-02 11:01 ` [PATCH bpf-next v3 08/15] xsk: wire up XDP_DRV side of AF_XDP Björn Töpel
2018-05-02 11:01 ` [PATCH bpf-next v3 09/15] xsk: wire up XDP_SKB " Björn Töpel
2018-05-02 11:01 ` [PATCH bpf-next v3 10/15] xsk: add umem completion queue support and mmap Björn Töpel
2018-05-02 11:01 ` [PATCH bpf-next v3 11/15] xsk: add Tx queue setup and mmap support Björn Töpel
2018-05-02 11:01 ` [PATCH bpf-next v3 12/15] dev: packet: make packet_direct_xmit a common function Björn Töpel
2018-05-02 11:01 ` [PATCH bpf-next v3 13/15] xsk: support for Tx Björn Töpel
2018-05-02 11:01 ` [PATCH bpf-next v3 14/15] xsk: statistics support Björn Töpel
2018-05-02 11:01 ` [PATCH bpf-next v3 15/15] samples/bpf: sample application and documentation for AF_XDP sockets Björn Töpel
2018-05-02 20:59 ` Jesper Dangaard Brouer
2018-05-03 13:55 ` [PATCH bpf-next v3 00/15] Introducing AF_XDP support Willem de Bruijn
2018-05-03 15:07 ` David Miller
2018-05-03 22:49 ` Daniel Borkmann
2018-05-03 23:38 ` Alexei Starovoitov
2018-05-04 11:22 ` Magnus Karlsson
2018-05-05 0:34 ` Alexei Starovoitov
2018-05-07 9:13 ` Magnus Karlsson
2018-05-07 13:09 ` Jesper Dangaard Brouer
2018-05-07 19:47 ` Björn Töpel
2018-05-17 6:46 ` Björn Töpel
2018-05-18 3:38 ` Alexei Starovoitov
2018-05-18 13:43 ` Daniel Borkmann
2018-05-18 15:18 ` Björn Töpel
2018-05-18 16:17 ` Daniel Borkmann
2018-05-18 16:32 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ+HfNjrqbMHRoA7-Zc4xEvDxpbqcRFcMYXkOF2Ns6UdGD9osQ@mail.gmail.com \
--to=bjorn.topel@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=anjali.singhai@intel.com \
--cc=ast@fb.com \
--cc=bjorn.topel@intel.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=jesse.brandeburg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=michael.lundkvist@ericsson.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=qi.z.zhang@intel.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).