From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB04EC43217 for ; Fri, 18 Nov 2022 19:57:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231640AbiKRT5P (ORCPT ); Fri, 18 Nov 2022 14:57:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231410AbiKRT5O (ORCPT ); Fri, 18 Nov 2022 14:57:14 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5991C0521 for ; Fri, 18 Nov 2022 11:57:12 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id m14so5429761pji.0 for ; Fri, 18 Nov 2022 11:57:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JQWsUxn8iwDG50vb73epK+aFJHJq3RHHQdvaYLtLc8M=; b=IhIDSHWHRA81XwNFxfXs+jo0NJ3lWJ8tuEBe+JujRGcXjrjswvxlmNznET4cKtE8an 6KezJ3dOjrK5IkAW9lFUdIYD6oJ/XRjJJbojEa4utMg32tUa9JEbBfobHPeHa0EbQRFe l1D8tobow+LbkZxnaf/6WlYRSkTV2Uk9yu0yh0Texq6Rno2f1g+kobJKa/oR/5gQFEbV oGbltDDYy0pEySTtpHAqT8DQRYlI32qziiQtPWQfqmEafItXYO3X8SD5W9Yu3NucmZtX gzRtim1vu++2MCVW7OL0zWqigD7aw8rrBbNpNj67c5wdK/sS0R+aqnyyqBRRqdl+NfpS zuDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JQWsUxn8iwDG50vb73epK+aFJHJq3RHHQdvaYLtLc8M=; b=DjAWrNE5+QoEoKrRZ77NgYUNNucwb6HyAxkgXo7OsMGmbfVuO6Hc+2p2sNLNjYSRkB 0K2gNZeeUEB3G8Tvh+2LYH+jbbVRkCARfw20HtSdatSuVPpXDRDQc2YlhN9BbM1H2Ft3 dpso2wFMAl4z6CShK0UkArGEw1/yAT2nBeCvUGHGSW6HrZqV/g8JpgyV2UwOj5Z/Hgci yQLRorXajiX9gYE5TFXsMWjqa75IlNe2NE7ertCCrkoREVbqfIq/8litXANvRX2TCURn xIZBj/67a39b+sP/2xf+/q5AEsnyE/Xm1z6J2QQ+xsBZry/mr3Y31PoKRIffhlZjundT ka+A== X-Gm-Message-State: ANoB5plmHXbpnbRP4Aa+yHeRQ3bDYjy7mZ77gmvfztpi8Y1VCkV9sdoR 9KKc3xqZV92nRA4OnZRDdijAjGU6uDWnxGPtVaYK8A== X-Google-Smtp-Source: AA0mqf43YPBp3+KpbsgaAKdhmrBTJiXYpRzURkCyO4fCvPlmnwD0CRqnmlgwCmYN+Q/zK2V2FLZYEkZUnfUzBWkyJkY= X-Received: by 2002:a17:902:a5cc:b0:186:de87:7ffd with SMTP id t12-20020a170902a5cc00b00186de877ffdmr949005plq.94.1668801432393; Fri, 18 Nov 2022 11:57:12 -0800 (PST) MIME-Version: 1.0 References: <20221118001548.635752-1-tharvey@gateworks.com> In-Reply-To: From: Tim Harvey Date: Fri, 18 Nov 2022 11:57:00 -0800 Message-ID: Subject: Re: [PATCH 0/3] add dt configuration for dp83867 led modes To: Andrew Lunn , Ansuel Smith Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Heiner Kallweit , Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Nov 18, 2022 at 5:11 AM Andrew Lunn wrote: > > > Andrew, > > > > I completely agree with you but I haven't seen how that can be done > > yet. What support exists for a PHY driver to expose their LED > > configuration to be used that way? Can you point me to an example? > > Nobody has actually worked on this long enough to get code merged. e.g. > https://lore.kernel.org/netdev/20201004095852.GB1104@bug/T/ > https://lists.archive.carbon60.com/linux/kernel/3396223 > > This is probably the last attempt, which was not too far away from getting merged: > https://patches.linaro.org/project/linux-leds/cover/20220503151633.18760-1-ansuelsmth@gmail.com/ > > I seem to NACK a patch like yours every couple of months. If all that > wasted time was actually spent on a common framework, this would of > been solved years ago. > > How important is it to you to control these LEDs? Enough to finish > this code and get it merged? > Andrew, Thanks for the links - the most recent attempt does look promising. For whatever reason I don't have that series in my mail history so it's not clear how I can respond to it. Ansuel, are you planning on posting a v7 of 'Adds support for PHY LEDs with offload triggers' [1]? I'm not all that familiar with netdev led triggers. Is there a way to configure the default offload blink mode via dt with your series? I didn't quite follow how the offload function/blink-mode gets set. Best Regards, Tim [1] https://patches.linaro.org/project/linux-leds/list/?submitter=10040