From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7BC8C31E57 for ; Mon, 17 Jun 2019 11:16:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BFF82084D for ; Mon, 17 Jun 2019 11:16:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="iAwdTAm7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727923AbfFQLQW (ORCPT ); Mon, 17 Jun 2019 07:16:22 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:37873 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727796AbfFQLQW (ORCPT ); Mon, 17 Jun 2019 07:16:22 -0400 Received: by mail-lf1-f66.google.com with SMTP id d11so6209229lfb.4 for ; Mon, 17 Jun 2019 04:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Az1PsId6AG7zrE/e92guw8M5OvqzRvBrnplgaPfEwcw=; b=iAwdTAm7d1j7Fy86A9WNwUIIPoE1zIu2cV4bWwdR7BuLmdfbtfKcJmSezpSob9uyX6 y01FclKM/Is3Qb4jVv6QnxM9EQcvoE6xuynnh4PECqeAadE1vTbXCLgg36nhvpqtTjy9 493u6NeeunXp2GdJ9WoAkK6KyTeTuImRWpp2rEmUCTZkMid45PFKnhZ7xih/PSPBJJfZ nEkQah3nMTlY7wOG9SwxnT1Kac1SB2teBXGdpQgu+dbRanIAymF8wsE8codJrzZ6jMZ9 r4V+5Vlqqk4S8kHnoDPpUOXQVEn0arHZ4O/7gv7E9mxTOtL+KUf2kc2uvhkSY+qIvuq6 iP0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Az1PsId6AG7zrE/e92guw8M5OvqzRvBrnplgaPfEwcw=; b=t8oKXQTm3E5RdXTA73QeV7nX+93g9WyAwPWZYGu3f+WKesXqO9upJfXGZ4wKf3eyTT s52BjzVYmbRcLASQ8/6Iug7utpMAJqETj23LP6YT1lGEbCKsg7a7jZs4WC1SgVfiSqbf tI297ixDnEftKIzxN6KHYFePslSz68actkJd5yuJlMpLbZlgR9YJFaLmT75RGBqCu7Dx 5JmuB9u8ExrUdgRTUfTBo8t7F1QIL+/3lqL+LASQWr9kP+h6S0ApSx7OxpV3F0XsEmOH RKnUCarBGarsjRUSn6P/VTpoiqSG3JhfKqYq9vSHuEEYhHtA3BkQNicZdbkKjq7MwZ4T LGRA== X-Gm-Message-State: APjAAAVZL4Kmk+qrjqC5otM/QQfN9BrAUujBNUdA+1qPE6vyDO0zbjzv +/moysgZw2+IPP6mCzAIdOH1MzacV6MyhwXCE82Ydg== X-Google-Smtp-Source: APXvYqypsC4+KqqqqByXUQwFLS5k7sdZwXfVUz0JR59Biy8/qI2ghsrwN4NbcoApA/Kx9X1aql6XpI8678au/x+gMGg= X-Received: by 2002:ac2:446b:: with SMTP id y11mr49980373lfl.158.1560770180454; Mon, 17 Jun 2019 04:16:20 -0700 (PDT) MIME-Version: 1.0 References: <1560745167-9866-1-git-send-email-yash.shah@sifive.com> In-Reply-To: From: Yash Shah Date: Mon, 17 Jun 2019 16:45:44 +0530 Message-ID: Subject: Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000 To: Paul Walmsley Cc: Andreas Schwab , David Miller , devicetree@vger.kernel.org, netdev , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Rob Herring , Mark Rutland , Nicolas Ferre , Palmer Dabbelt , Albert Ou , =?UTF-8?Q?Petr_=C5=A0tetiar?= , Sachin Ghadi , Sagar Kadam Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 17, 2019 at 3:58 PM Paul Walmsley wrote: > > On Mon, 17 Jun 2019, Yash Shah wrote: > > > On Mon, Jun 17, 2019 at 3:28 PM Paul Walmsley wrote: > > > > > On Mon, 17 Jun 2019, Andreas Schwab wrote: > > > > > > > On Jun 17 2019, Yash Shah wrote: > > > > > > > > > - Add "MACB_SIFIVE_FU540" in Kconfig to support SiFive FU540 in macb > > > > > driver. This is needed because on FU540, the macb driver depends on > > > > > SiFive GPIO driver. > > > > > > > > This of course requires that the GPIO driver is upstreamed first. > > > > > > What's the impact of enabling CONFIG_MACB_SIFIVE_FU540 when the GPIO > > > driver isn't present? (After modifying the Kconfig "depends" line > > > appropriately.) > > > > > > Looks to me that it shouldn't have an impact unless the DT string is > > > present, and even then, the impact might simply be that the MACB driver > > > may not work? > > > > Yes, there won't be an impact other than MACB driver not working. > > OK. In that case, there doesn't seem much point to adding the Kconfig > option. Could you please post a new version without it? Sure, will do that. > > > In any case, without GPIO driver, PHY won't get reset and the network > > interface won't come up. > > Naturally, in the medium term, we want Linux to handle the reset. But if > there's no GPIO driver present, and the bootloader handles the PHY reset > before the kernel starts, would the network driver work in that case? Yes, if bootloader handles the PHY reset then the network driver will work in that case. I will post a new version without the GPIO driver dependency. > > > - Paul