From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BE57C43381 for ; Tue, 26 Feb 2019 22:41:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B453218D9 for ; Tue, 26 Feb 2019 22:41:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cz26GMmP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729234AbfBZWld (ORCPT ); Tue, 26 Feb 2019 17:41:33 -0500 Received: from mail-yw1-f66.google.com ([209.85.161.66]:39676 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728766AbfBZWld (ORCPT ); Tue, 26 Feb 2019 17:41:33 -0500 Received: by mail-yw1-f66.google.com with SMTP id z191so5937901ywa.6 for ; Tue, 26 Feb 2019 14:41:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ESBw14FHoqlWZgUb6Zf+O4mJC+71fjLAB9tIhkhhOLs=; b=cz26GMmPEsZPb+0eArIx06HWLUUIss36U33JKIqL8zhbxzGaopJPvseZu6OBlpOCL2 q8iTFAjaaxImuP9OToulIPLyAfmGjqaPHGmITrjNW1l3wwNbCDMFT9UcNohUZtbc17AN hIm0YFvVlbffWb9CZ6A+eJSpxRK0Gsmk5zyOrhkUAUydWT9jDDhyaO7GKghgTfn1wGdo NMMOf0iADIAF6UyUcTBVijCyc0lVJCwGqG7taBdZqxKJMxT4mL9Q3LP0h9tq6jRQy2tq UDabv1Ef9CikVkC9M66wclXhAIOPjdPX9eVkHd4/gerYS45QcXFHLMFn/8d/X/+Kkj0Z Mkdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ESBw14FHoqlWZgUb6Zf+O4mJC+71fjLAB9tIhkhhOLs=; b=re/uR9dLUfzXatKv3Am1AtKGhgZ6Gh0ucdrzj0nhyLWRHDpEJ4hjtu2wP74JJDRgMG 6UF/x2xvfYre8jm1vdtSIWuTXPlGpZBm1sJtoF9k4gKsr1McafPcuIYpzNyTjRLU4INN zaQO/xOcMPG1PxPA1f+TXUkqK7gAFh9i/oSH0qsJDAifKG39uHfDhlZIOM2cXkkaS7yY A3JLd29RGar//FzYMSQCCyh1ZQ/B48KxpjHsVE5euxfkIDW6QSBr8MoBGJNSfilVUqlr f5mz1bpKPxl3+pxzF2VZPwAzJFBkCbIQlVALzUQBC9YwHG/1LNGMHnSBxqPIuW3vUYfG 0YhQ== X-Gm-Message-State: AHQUAuYjJJMNIdW7vLIJhjqjj1w8uOovm5m4Q9C+kLjVlKmeRQmMBz3t bmzeJI1N2DUzQLBKXQrL0Y2xrJIJ6ku6Df/YebxOr3V2 X-Google-Smtp-Source: AHgI3IbeYWiywTUVYoGOcT6mU9Ray0NiI9epKhm1YRqepDMtchCq06bmzPlLc+cNeFZ9+EcXar2a0QhRIf07nQJfOU8= X-Received: by 2002:a25:23ce:: with SMTP id j197mr12357612ybj.145.1551220892664; Tue, 26 Feb 2019 14:41:32 -0800 (PST) MIME-Version: 1.0 References: <1551091207-10366-1-git-send-email-xiangxia.m.yue@gmail.com> <1551091207-10366-2-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: <1551091207-10366-2-git-send-email-xiangxia.m.yue@gmail.com> From: Or Gerlitz Date: Wed, 27 Feb 2019 00:41:18 +0200 Message-ID: Subject: Re: [PATCH net-next v2 1/5] net/mlx5e: Return -EOPNOTSUPP when modify header action zero To: Tonghao Zhang Cc: Saeed Mahameed , Linux Netdev List Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 25, 2019 at 1:06 PM wrote: > When max modify header action is zero, we return -EOPNOTSUPP > directly. In this way, we can ignore wrong message info (e.g. > "mlx5: parsed 0 pedit actions, can't do more"). > > This happens when offloading pedit actions on mlx VFs. this command should work, we support header re-write (pedit offload) for tc NIC rules Is this CX5 VF? if yes, something broke > For example: > $ tc filter add dev mlx5_vf parent ffff: protocol ip prio 1 \ > flower skip_sw dst_mac 00:10:56:fb:64:e8 \ > dst_ip 1.1.1.100 src_ip 1.1.1.200 \ > action pedit ex munge eth src set 00:10:56:b4:5d:20