From: Or Gerlitz <gerlitz.or@gmail.com>
To: Saeed Mahameed <saeedm@mellanox.com>,
Achiad Shochat <achiad@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Eran Ben Elisha <eranbe@mellanox.com>,
Tal Alon <talal@mellanox.com>, Majd Dibbiny <majd@mellanox.com>,
Saeed Mahameed <saeedm@dev.mellanox.co.il>
Subject: Re: [PATCH net-next V2 1/4] net/mlx5e: Do not modify the TX SKB
Date: Mon, 21 Dec 2015 07:05:05 +0200 [thread overview]
Message-ID: <CAJ3xEMiPYAFmKfF7_QJoOy++7y3FqNCWd7zzDz7xe5xdtvVXgQ@mail.gmail.com> (raw)
In-Reply-To: <1450647991-13736-2-git-send-email-saeedm@mellanox.com>
On Sun, Dec 20, 2015 at 11:46 PM, Saeed Mahameed wrote:
> From: Achiad Shochat <achiad@mellanox.com>
>
> If the SKB is cloned, or has an elevated users count, someone else
> can be looking at it at the same time.
> drivers/net/ethernet/mellanox/mlx5/core/en.h | 5 +-
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 5 +-
> drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 73 ++++++++++++---------
> 3 files changed, 49 insertions(+), 34 deletions(-)
Guys, can this can be made in a manner which is lighter w.r.t data
path changes? lets make sure we do things (1) right and (2) efficient
Or.
next prev parent reply other threads:[~2015-12-21 5:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 21:46 [PATCH net-next V2 0/4] Introduce mlx5 ethernet timestamping Saeed Mahameed
2015-12-20 21:46 ` [PATCH net-next V2 1/4] net/mlx5e: Do not modify the TX SKB Saeed Mahameed
2015-12-21 5:05 ` Or Gerlitz [this message]
2015-12-20 21:46 ` [PATCH net-next V2 2/4] net/mlx5_core: Add support for reading hardware timestamp Saeed Mahameed
2015-12-20 21:46 ` [PATCH net-next V2 3/4] net/mlx5e: Add HW timestamping (TS) support Saeed Mahameed
2015-12-21 9:15 ` Richard Cochran
2015-12-21 14:35 ` Saeed Mahameed
2015-12-21 18:35 ` Richard Cochran
2015-12-22 9:56 ` Saeed Mahameed
2015-12-22 10:00 ` Saeed Mahameed
2015-12-22 17:01 ` Richard Cochran
2015-12-24 14:02 ` eran ben elisha
2015-12-20 21:46 ` [PATCH net-next V2 4/4] net/mlx5e: Add PTP Hardware Clock (PHC) support Saeed Mahameed
2015-12-21 9:16 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3xEMiPYAFmKfF7_QJoOy++7y3FqNCWd7zzDz7xe5xdtvVXgQ@mail.gmail.com \
--to=gerlitz.or@gmail.com \
--cc=achiad@mellanox.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=majd@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@dev.mellanox.co.il \
--cc=saeedm@mellanox.com \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).