From: Or Gerlitz <gerlitz.or@gmail.com>
To: Yishai Hadas <yishaih@nvidia.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Doug Ledford <dledford@redhat.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Parav Pandit <parav@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH net-next RESEND 2/2] net/mlx5: E-Switch, Implement devlink port function cmds to control roce
Date: Tue, 2 Feb 2021 21:11:28 +0200 [thread overview]
Message-ID: <CAJ3xEMid_wMdJ_bArXvzO1BCFJNU4s5_+555ywD3iW1DvdYztA@mail.gmail.com> (raw)
In-Reply-To: <20210202080614.37903-3-yishaih@nvidia.com>
On Tue, Feb 2, 2021 at 10:08 AM Yishai Hadas <yishaih@nvidia.com> wrote:
> Implement devlink port function commands to enable / disable roce.
> This is used to control the roce device capabilities.
[..]
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.h
> @@ -122,8 +122,9 @@ struct mlx5_vport_info {
> int link_state;
> u32 min_rate;
> u32 max_rate;
> - bool spoofchk;
> - bool trusted;
> + u8 spoofchk: 1;
> + u8 trusted: 1;
> + u8 roce_enabled: 1;
> };
This struct has attributes which have e-switch vport affiliation where
roce enable/disable
is a property of the vhca function-over-the-e-wire -- it's that we do
something specific
in the e-switching to enforce - sounds like a problematic location to
land the bit..
prev parent reply other threads:[~2021-02-02 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 8:06 [PATCH net-next RESEND 0/2] devlink: Add port function attribute to enable/disable roce Yishai Hadas
2021-02-02 8:06 ` [PATCH net-next RESEND 1/2] devlink: Expose port function commands to control roce Yishai Hadas
2021-02-02 8:06 ` [PATCH net-next RESEND 2/2] net/mlx5: E-Switch, Implement devlink port function cmds " Yishai Hadas
2021-02-02 19:11 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3xEMid_wMdJ_bArXvzO1BCFJNU4s5_+555ywD3iW1DvdYztA@mail.gmail.com \
--to=gerlitz.or@gmail.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).