From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C0B2C4338F for ; Wed, 4 Aug 2021 13:27:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E74760F56 for ; Wed, 4 Aug 2021 13:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238418AbhHDN1X (ORCPT ); Wed, 4 Aug 2021 09:27:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238126AbhHDN1F (ORCPT ); Wed, 4 Aug 2021 09:27:05 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B22A8C061799 for ; Wed, 4 Aug 2021 06:26:42 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id 188so647304ioa.8 for ; Wed, 04 Aug 2021 06:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dYdEg3FEjnNJNThyUvC517fEe1eHnKogxE9Vzfv1UIY=; b=pyuZLS/FOfE/HBGll+dPoZ1LtOgBykNvSiMNx5Kqhp/Ypy+svNMfDD4IVaPagLGLoM L4MXI00DzGsGUTi/nnu23RMlKv8X7QhmSMuEJd9dTbLVyLWHuMGhbM4Qhm/aMxyeeUOq nUmTi63s/xOtwLZZN465P50BtDaubNZgKKGjf4wPW0E2x5c5OQrJ+TXEIMxeYWw+cKny idm9y51ARmYxC58XFBZOk1Km6GxfVy02QHpI3wWp+eLFOrvciJzlQEHsYDWGqXQ306SC 3aD++ejy5rJMQyjyg1daDJhKE0rJYoa5ZDskmj+BuZ2HLfzTcE58/6fW+mRVS0Vw7YV7 kPHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dYdEg3FEjnNJNThyUvC517fEe1eHnKogxE9Vzfv1UIY=; b=sq3cFPtz9V1+YI0GCIkC1yB8iApHuZcce6sHqqAABl7uPesEkpFm4dIy41PHHBUVa2 T9NQ3UaaBHPBCE89CKfxbpml4UeDyRCTu6OaKihDOAG0S7plwdy0YOZ37V6CJLx3yRwL U5RrSvkzfRSx7T6tBNbjMc3P5LDr0jXSzPFeM0Y3MXPEoEqWwTMyOwni46eqS2p8mbc/ lgNJH1sXs+rONoWLcFK740nE5Z9fQHeWXwzEcJ5pbOXU+DyFniDU7pg/m8RWfuWE8yIf GqBaAbZYffB5G6JnKwGwErrZioI+nOr1xEt9U8Vb/mpuZVAxUdSHzqBmwuDqiQHBIuqN AFsw== X-Gm-Message-State: AOAM532CsqwAqbjBOYzrHEwU+RqYRZX6SA6FD6aA4nDXMi4pGtW80Mbd CZ3+HhbSCFZJu/CxTlpW4eYJxRhaqqk42HXnxKQ= X-Google-Smtp-Source: ABdhPJwHCkpNkLRfonCftH7xrpR5xKYOfBuU7tCEvKhzz4cL8l/tVlCLekEnJrlwYG79KY2VRUDXt2bCOoRTN5pbiAM= X-Received: by 2002:a6b:e602:: with SMTP id g2mr286609ioh.50.1628083602175; Wed, 04 Aug 2021 06:26:42 -0700 (PDT) MIME-Version: 1.0 References: <20210722110325.371-1-borisp@nvidia.com> <20210722110325.371-5-borisp@nvidia.com> <20210723060631.GA32369@lst.de> In-Reply-To: <20210723060631.GA32369@lst.de> From: Or Gerlitz Date: Wed, 4 Aug 2021 16:26:31 +0300 Message-ID: Subject: Re: [PATCH v5 net-next 04/36] net/tls: expose get_netdev_for_sock To: Christoph Hellwig , Jakub Kicinski Cc: Boris Pismenny , David Miller , Saeed Mahameed , Sagi Grimberg , axboe@fb.com, Keith Busch , Alexander Viro , Eric Dumazet , Shai Malin , boris.pismenny@gmail.com, linux-nvme@lists.infradead.org, Linux Netdev List , benishay@nvidia.com, Or Gerlitz , Yoray Zack , David Ahern Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jul 23, 2021 at 9:09 AM Christoph Hellwig wrote: > > On Thu, Jul 22, 2021 at 02:02:53PM +0300, Boris Pismenny wrote: > > From: Boris Pismenny > > > > get_netdev_for_sock is a utility that is used to obtain > > the net_device structure from a connected socket. > > > > Later patches will use this for nvme-tcp DDP and DDP DDGST offloads. > > > > Signed-off-by: Boris Pismenny > > Reviewed-by: Sagi Grimberg > > I don't think this should be an inline. Please move it to net/core/dev.c, > andd add an EXPORT_SYMBOL_GPL and a kerneldoc comment. Jakub, What's your preference here? Or.