From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A219DC43381 for ; Thu, 21 Feb 2019 16:27:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7006D2077B for ; Thu, 21 Feb 2019 16:27:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PYLsJMJS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727212AbfBUQ1E (ORCPT ); Thu, 21 Feb 2019 11:27:04 -0500 Received: from mail-yw1-f67.google.com ([209.85.161.67]:44846 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbfBUQ1D (ORCPT ); Thu, 21 Feb 2019 11:27:03 -0500 Received: by mail-yw1-f67.google.com with SMTP id x21so11001036ywx.11 for ; Thu, 21 Feb 2019 08:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PXJC3+6VwpBul1xJOOY8fY30QBlaXr7nVK29pg89xlc=; b=PYLsJMJScECCRMGtLb4cjV3oaeaSJ1GYxbPcfnya8sZ4c5Nmm15qP7Jp8QANoz3eTb w9t9+YhSAYkFwFyF39C5qUDBZm+DZ86acyymfrd8DfyzG5pCIIHdYs4gLqPEM+qoEVHP iaHEpRPTRfqEZEYucGBHcC4LAo7g+/GUL9SNGPyOVnrx/j0t7g+0hoVZJWLEyEVt0VWk 3T2WS9cp0NVtjjIx00qdqjiKEEFZRytpEemsZgsT4chs02IczNAmwSq6aOr3VU2cNl8/ FjasY2+R5ifTTCt9sqM3PA0U586+dIwG8Mgh8y+yRTuRCjrOrkSGaZM79JxwZNZ/kxIi 4Dwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PXJC3+6VwpBul1xJOOY8fY30QBlaXr7nVK29pg89xlc=; b=MgCKfmWB0enfD3ZP9GyOTcXyxl5RvRLdAItAN4ChDsBX7v5lSd4qEs1cpVbRxyNBBd nDp5WW+qOCPnDOzWBMozqAFK6fb13o+jhHY6ovv50Zk/+hpiebFAX+NyVxm7cH1xwP0p IE5RUAbgZAdgYhveUIW/ceIRePiMc2fEV01BDbUd1tlfLfJigUzjf1X/zefzOVcJQqVY eY42MF7OgFPWpEY9zX7j7BNx3gf4HW/SlOtdsWHSbKDxflIJS+8deIttE0HI/XGVogyl DhjXGYwnKOIKK19B+V9Y+FbWPnJCeVPMu55R/rNjhx9JKUbPYmfGeOP19FyGbnHE4iet HCfA== X-Gm-Message-State: AHQUAuYJQzGHSJMbXPLHo8yFL8Ha6cOIUMRnA7KfN0dv4IgeI2W2uOxg lakDNf9ZU+H9n9zX8QYn0gP/cBDukUYUpV7NkxY= X-Google-Smtp-Source: AHgI3Ib/eBGgD5/0koKZZOtIaqEG3X1aYG4vS1BsvT9X04EfWwYV7aQSRDYXOTGu0X9RpMyV1jeMoz+brPWZTGyWqN8= X-Received: by 2002:a5b:98c:: with SMTP id c12mr32811367ybq.280.1550766423033; Thu, 21 Feb 2019 08:27:03 -0800 (PST) MIME-Version: 1.0 References: <1550715283-23579-1-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: <1550715283-23579-1-git-send-email-xiangxia.m.yue@gmail.com> From: Or Gerlitz Date: Thu, 21 Feb 2019 18:26:51 +0200 Message-ID: Subject: Re: [PATCH net-next 1/5] net/mlx5e: Return -EOPNOTSUPP when modify header action zero To: Tonghao Zhang Cc: Saeed Mahameed , Linux Netdev List Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 21, 2019 at 3:42 PM wrote: > else /* namespace is MLX5_FLOW_NAMESPACE_KERNEL - NIC offloading */ > max_actions = MLX5_CAP_FLOWTABLE_NIC_RX(priv->mdev, max_modify_header_actions); > > + if (!max_actions) { > + NL_SET_ERR_MSG_MOD(extack, > + "don't support pedit actions, can't offload"); > + netdev_warn(priv->netdev, "don't support pedit actions, can't offload\n"); it's not going to work if we keep filling the driver with duplicated error messages, stick to extack only Also, when you respin with comments provided on this submission, please send also cover letter which is going to be "[PATCH net-next 00/05] ... " use --cover-letter for git format-patch and edit it after creation