From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EBDEC4338F for ; Wed, 4 Aug 2021 15:07:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BA5460FC3 for ; Wed, 4 Aug 2021 15:07:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238225AbhHDPHo (ORCPT ); Wed, 4 Aug 2021 11:07:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237378AbhHDPHl (ORCPT ); Wed, 4 Aug 2021 11:07:41 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6580C0613D5 for ; Wed, 4 Aug 2021 08:07:28 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id h1so2750712iol.9 for ; Wed, 04 Aug 2021 08:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RWDjzodGnhZfwxccSgG7VT6HhBEQtoLSkZbWFg0VfT8=; b=EmFXLVq9TtTpkgJ8rvOAI08qcDBQyB+Fv/L06hjYiodSgH+GQXZoptoIVMjlMBpUGB lUBkkEgvvn+XCKIl1y38imCqmqJEYPx2qWwmuzhr3bYBNEYjYrboAw4xV6kK5Y2SLPf8 wlfUfhkE4K03tcMz6m1Zq6ffzS/j9TADLti8D80Xf6Y0+yS2FcAGFhXWOmo1ke/nJgd0 6/LI9fr1rptjBu6LCACpG4mKhYUBbBp3NhDM5O0IC8pEcXbZMFHHs5h6xNZ3CTuFbd7y MKpND5KTueImSMbVOIakr/y7PLYIPGV+V2Gm56tW8gNLKo6IcfkzPweXO3RFgqruMRp6 pEWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RWDjzodGnhZfwxccSgG7VT6HhBEQtoLSkZbWFg0VfT8=; b=WuvCXrMzUzmBpo6zuvgPujHot0soJREDbb/WiKailYtImpYijdnYxugKUAYVbxHbEM FfIH57Oqg+sysUGyKDL3y5IjYOx2Hd4K7KJKUUKEetiYtegU8jN9Hh/WOVGcvQ5cKZcq iEAITcbFWBpQXb1s4gEchS/iAjWZWmMvBojZUoJcC0pAWvN6jCMJmy5BLRDHHrNWGuz5 vSegWjQrzlRcB5tgXVEEnEowHYzgEjNbfJvk40Za1nCaB07t0Tik7aNIc85idPH1ymI6 2di5Gn+8IjnUF4uLJHbyMvPoMar6yYD50LMVgVtK+XL6nIZog/TRDCubGjReF9J++hwH 9MhQ== X-Gm-Message-State: AOAM5335e9Ypd88A75tgxyzWzI9REBcVzZOj72XCzdEKCG4uIs0u3ddt y+f2pVQOzIJBCRPf2W3t5sUv1zMYAoyIrikZZ/w= X-Google-Smtp-Source: ABdhPJxhAeob5VyA2a0O34Fhx3Mo2JxS+SrD/RJaxIL51y9TwrahhsvLd6MSZbDfdQ+7N9NXh0pghsqn7c1g0msyTDg= X-Received: by 2002:a6b:e602:: with SMTP id g2mr641933ioh.50.1628089648273; Wed, 04 Aug 2021 08:07:28 -0700 (PDT) MIME-Version: 1.0 References: <20210722110325.371-1-borisp@nvidia.com> <20210722110325.371-5-borisp@nvidia.com> <20210723060631.GA32369@lst.de> <20210804072918.17ba9cff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210804072918.17ba9cff@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Or Gerlitz Date: Wed, 4 Aug 2021 18:07:06 +0300 Message-ID: Subject: Re: [PATCH v5 net-next 04/36] net/tls: expose get_netdev_for_sock To: Jakub Kicinski Cc: Boris Pismenny , Linux Netdev List , Sagi Grimberg , Christoph Hellwig , Yoray Zack , benishay@nvidia.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 4, 2021 at 5:29 PM Jakub Kicinski wrote: > > On Wed, 4 Aug 2021 16:26:31 +0300 Or Gerlitz wrote: > > On Fri, Jul 23, 2021 at 9:09 AM Christoph Hellwig wrote: > > > On Thu, Jul 22, 2021 at 02:02:53PM +0300, Boris Pismenny wrote: > > > > From: Boris Pismenny > > > > > > > > get_netdev_for_sock is a utility that is used to obtain > > > > the net_device structure from a connected socket. > > > > > > > > Later patches will use this for nvme-tcp DDP and DDP DDGST offloads. > > > > > > > > Signed-off-by: Boris Pismenny > > > > Reviewed-by: Sagi Grimberg > > > > > > I don't think this should be an inline. Please move it to net/core/dev.c, > > > andd add an EXPORT_SYMBOL_GPL and a kerneldoc comment. > > > > Jakub, > > > > What's your preference here? > > Fine either way. copying the list and few ppl