From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D020BC48BE8 for ; Mon, 14 Jun 2021 08:49:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFA57613C5 for ; Mon, 14 Jun 2021 08:49:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232621AbhFNIv0 (ORCPT ); Mon, 14 Jun 2021 04:51:26 -0400 Received: from mail-pj1-f53.google.com ([209.85.216.53]:38586 "EHLO mail-pj1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232670AbhFNIvV (ORCPT ); Mon, 14 Jun 2021 04:51:21 -0400 Received: by mail-pj1-f53.google.com with SMTP id m13-20020a17090b068db02901656cc93a75so9616506pjz.3; Mon, 14 Jun 2021 01:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fJXJGzo/AzgCmmowETTvaQsC6wM1vEXUdgM3CM2feig=; b=DR8XsVbIMAQmQZl0SDZT64onM6mKvDo1FjbYxpmabg73JiYivmZ2QtqgKinbKLs/As kT5f0WNmUW8J3a99MtlJZXiz6iFc0L9YEXKNtlUrvz3l8Fg3RFrL/3umd4VJSRKYKUgq p+QiVcLukjjwIjYf42Gxeav1ASTrwtdOSbzTT6MiVUc9VZTlSSN9sYY47Viiutixk3l2 kwF+RbgvsUXlfQAAQcTUrDW9kN8/Fr3sxCBqecShSRJ5OVlp9TGCFgCkhQx8pp8QA0GA cG4r13wNzQI7SmiM/DcN/vgxmVjbDFOediF8cI5pfF5vD/sk6CgzA/uppfPa+umyvVAY X8nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fJXJGzo/AzgCmmowETTvaQsC6wM1vEXUdgM3CM2feig=; b=dYuGUkUFH/+NHizS6wJ0oRE8oUEQyeA/+hXWyZqm2UGTPxHSSd0qBCoZxXAe0qpJXK eHr2ccKM96eE77dgYF+7swvHPXh+LfnkNBUkZ8x3lGZAXediSklLy+IatLHE7go3S41L FoaTszMQE/1FxNOTkk52/KFM+F2DIVatzfb/CIY9Q8lZvbVrTbCeliz1WlDQ0l/nU1HL P2M0sSjqdXEXb61EL0QD7XJmhpj5R1Uts7MJL/ojO5feaaEZUe+6GmUKZeplN0j5zhKZ RMsPzSujy0wxgy4sodKB+GXFtEzIk+SY7aOFerHiiqjvJhzdsNIPvsMOzy0dAs1TOP+K ixoA== X-Gm-Message-State: AOAM530MeBjkmFJ//dJf3vuusdAjR0uK7ZbZA0yGUZoLKR2Dufzjh/si UdkOCuiZE0li8wJFVinuIRlhH8PAMDZ6bt9QeD8= X-Google-Smtp-Source: ABdhPJz4p3NEuzhCq5k17/OP2UCkWvocwhedF3qakqYiwvONLxK+8fohY6wDcDSsL6mkE3e6zGDkVkNuYEqt5SEoBnU= X-Received: by 2002:a17:902:dcce:b029:113:ad63:6f64 with SMTP id t14-20020a170902dcceb0290113ad636f64mr15676629pll.7.1623660498695; Mon, 14 Jun 2021 01:48:18 -0700 (PDT) MIME-Version: 1.0 References: <20210609135537.1460244-1-joamaki@gmail.com> <20210609135537.1460244-4-joamaki@gmail.com> <20210609220713.GA14929@ranger.igk.intel.com> In-Reply-To: From: Magnus Karlsson Date: Mon, 14 Jun 2021 10:48:07 +0200 Message-ID: Subject: Re: [PATCH bpf-next 3/3] selftests/bpf: Add tests for XDP bonding To: Jussi Maki Cc: Maciej Fijalkowski , bpf , Network Development , Daniel Borkmann , j.vosburgh@gmail.com, Andy Gospodarek , vfalico@gmail.com, Andrii Nakryiko , "Karlsson, Magnus" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 14, 2021 at 10:09 AM Jussi Maki wrote: > > On Thu, Jun 10, 2021 at 12:19 AM Maciej Fijalkowski > wrote: > > > > On Wed, Jun 09, 2021 at 01:55:37PM +0000, Jussi Maki wrote: > > > Add a test suite to test XDP bonding implementation > > > over a pair of veth devices. > > > > Cc: Magnus > > > > Jussi, > > AF_XDP selftests have very similar functionality just like you are trying > > to introduce over here, e.g. we setup veth pair and generate traffic. > > After a quick look seems that we could have a generic layer that would > > be used by both AF_XDP and bonding selftests. > > > > WDYT? > > Sounds like a good idea to me to have more shared code in the > selftests and I don't see a reason not to use the AF_XDP datapath in > the bonding selftests. I'll look into it this week and get back to > you. Note, that I am currently rewriting a large part of the AF_XDP selftests making it more amenable to adding various tests. A test is in my patch set is described as a set of packets to send, a set of packets that should be received in a certain order with specified contents, and configuration/setup information for the sender and receiver. The current code is riddled with test specific if-statements that make it hard to extend and use generically. So please hold off for a week or so and review my patch set when I send it to the list. Better use of your time. Hopefully we can make it fit your bill too with not too much work.