From: Magnus Karlsson <magnus.karlsson@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: "Magnus Karlsson" <magnus.karlsson@intel.com>,
"Björn Töpel" <bjorn.topel@intel.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Network Development" <netdev@vger.kernel.org>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
bpf@vger.kernel.org, bruce.richardson@intel.com,
ciara.loftus@intel.com, "Ye Xiaolong" <xiaolong.ye@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Maxim Mikityanskiy" <maximmi@mellanox.com>,
"Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
kevin.laatz@intel.com, ilias.apalodimas@linaro.org,
Kiran <kiran.patil@intel.com>,
axboe@kernel.dk, "Fijalkowski,
Maciej" <maciej.fijalkowski@intel.com>,
"Maciej Fijalkowski" <maciejromanfijalkowski@gmail.com>,
intel-wired-lan <intel-wired-lan@lists.osuosl.org>
Subject: Re: [PATCH bpf-next 2/6] xsk: add support for need_wakeup flag in AF_XDP rings
Date: Thu, 13 Jun 2019 21:07:26 +0200 [thread overview]
Message-ID: <CAJ8uoz0jXyVt8OPOq+B8L7gEm8bbd8cE5vdf3-KAhaVK871k8w@mail.gmail.com> (raw)
In-Reply-To: <20190613120411.35ef3c52@cakuba.netronome.com>
On Thu, Jun 13, 2019 at 9:05 PM Jakub Kicinski
<jakub.kicinski@netronome.com> wrote:
>
> On Thu, 13 Jun 2019 09:37:26 +0200, Magnus Karlsson wrote:
> >
> > - if (!dev->netdev_ops->ndo_bpf ||
> > - !dev->netdev_ops->ndo_xsk_async_xmit) {
> > + if (!dev->netdev_ops->ndo_bpf || !dev->netdev_ops->ndo_xsk_wakeup) {
> > err = -EOPNOTSUPP;
> > goto err_unreg_umem;
> > }
>
> > @@ -198,7 +258,8 @@ static int xsk_zc_xmit(struct sock *sk)
> > struct xdp_sock *xs = xdp_sk(sk);
> > struct net_device *dev = xs->dev;
> >
> > - return dev->netdev_ops->ndo_xsk_async_xmit(dev, xs->queue_id);
> > + return dev->netdev_ops->ndo_xsk_wakeup(dev, xs->queue_id,
> > + XDP_WAKEUP_TX);
> > }
> >
> > static void xsk_destruct_skb(struct sk_buff *skb)
>
> Those two look like they should be in the previous patch? Won't it
> break build?
You are correct. That should have been in patch 1. Will fix that in the v2.
Thanks: Magnus
next prev parent reply other threads:[~2019-06-13 19:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 7:37 [PATCH bpf-next 0/6] add need_wakeup flag to the AF_XDP rings Magnus Karlsson
2019-06-13 7:37 ` [PATCH bpf-next 1/6] xsk: replace ndo_xsk_async_xmit with ndo_xsk_wakeup Magnus Karlsson
2019-06-13 7:37 ` [PATCH bpf-next 2/6] xsk: add support for need_wakeup flag in AF_XDP rings Magnus Karlsson
2019-06-13 19:04 ` Jakub Kicinski
2019-06-13 19:07 ` Magnus Karlsson [this message]
2019-06-13 7:37 ` [PATCH bpf-next 3/6] i40e: add support for AF_XDP need_wakup feature Magnus Karlsson
2019-06-13 7:37 ` [PATCH bpf-next 4/6] ixgbe: " Magnus Karlsson
2019-06-13 7:37 ` [PATCH bpf-next 5/6] libbpf: add support for need_wakeup flag in AF_XDP part Magnus Karlsson
2019-06-13 7:37 ` [PATCH bpf-next 6/6] samples/bpf: add use of need_sleep flag in xdpsock Magnus Karlsson
2019-06-13 23:34 ` [Intel-wired-lan] [PATCH bpf-next 0/6] add need_wakeup flag to the AF_XDP rings Jeff Kirsher
2019-06-14 13:38 ` Maxim Mikityanskiy
2019-06-14 14:17 ` Maciej Fijalkowski
2019-06-15 19:13 ` Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ8uoz0jXyVt8OPOq+B8L7gEm8bbd8cE5vdf3-KAhaVK871k8w@mail.gmail.com \
--to=magnus.karlsson@gmail.com \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=daniel@iogearbox.net \
--cc=ilias.apalodimas@linaro.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jakub.kicinski@netronome.com \
--cc=kevin.laatz@intel.com \
--cc=kiran.patil@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=maciejromanfijalkowski@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=qi.z.zhang@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).