From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA9E8C282C7 for ; Thu, 31 Jan 2019 10:44:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72821218AC for ; Thu, 31 Jan 2019 10:44:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TOrWZU5R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732109AbfAaKoN (ORCPT ); Thu, 31 Jan 2019 05:44:13 -0500 Received: from mail-io1-f68.google.com ([209.85.166.68]:36120 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726221AbfAaKoN (ORCPT ); Thu, 31 Jan 2019 05:44:13 -0500 Received: by mail-io1-f68.google.com with SMTP id m19so2254000ioh.3 for ; Thu, 31 Jan 2019 02:44:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TsrN3lWD/c/Lofh1HtOMbxuEkI5Zj30U1njKgg9yXMk=; b=TOrWZU5R6/523Pa/PZxX5hFIcBuX8v337kPSrz9iza4X7QE/alTJ94FhqZwkEM7pMD 4yayqfXCQkf+wBKPfXCg0YlGbS5d6t8Vvg/9RZfR89vnNXsmcgH2YJh0RTo17cYwy3/q TdMCIGNeEm1MXPrRta0Xrg4LAPqdEp6cV3xv4m+K0aWp36hC76RIK8xT9DtwEGR6C/dE 28EP1UPUIpg5zQMAlQMtRruAb+UJZthNdNX3w8V+BSs+GSe1DAHkoPsiiNKIPp9lSGA5 JnW1YH75E8jNolju7BAAn4SJ0SL6uuzRr3+ogPUl7wOQ7zvMQp/daaXJXCY0q7mCTMqP CaHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TsrN3lWD/c/Lofh1HtOMbxuEkI5Zj30U1njKgg9yXMk=; b=cR1vNJ4pByvpponjkkZEcpjaHkAVTfwMCrzQdR/ELbFqLNkOxjw6moh0l3BWHYdueK WgQog0TcnZm3eUACmML5sg/lTy96RbDHSB7J9WEtJZmp3BOXi784ymBni5Ue/M4Cvzow xFKOsPr72wt3Do807iOSwmuA/DgR17fX/b6eFT7XfwihVzOEUsQ0hgMl96knrK3VTS7T 30Y6kxlKNouk3rCGYKlThv0BuyvEU99ncdMkcw+prGrsO/ydYNI7DYWQaGoUsqpKhF87 1H38rjw628AuJVSHo7sYp3Rl7nKgurerK2EMNQ2PHOFqPaO4ZW47VbbvicTVgKAr14N8 yDwg== X-Gm-Message-State: AHQUAuYSg7qSxKkzE/+YRm8I53z0dpC9QIVCTCvw2Ho5cUvVkTOF7QI6 VWlZKWMWWmVcIXhHOrDOEr5cph9aIHUrMtUtpmg= X-Google-Smtp-Source: AHgI3Ib+DJ5+bK7T4TOMavVzjPTvjUiAqpg6Tt2Lg1+/Uq3fbddmwbmgsMpB/zGV2k8BnI6g7tKHDrK/ByXdN/RiOts= X-Received: by 2002:a6b:b902:: with SMTP id j2mr20183254iof.220.1548931451787; Thu, 31 Jan 2019 02:44:11 -0800 (PST) MIME-Version: 1.0 References: <1548774737-16579-1-git-send-email-magnus.karlsson@intel.com> <1548774737-16579-3-git-send-email-magnus.karlsson@intel.com> In-Reply-To: From: Magnus Karlsson Date: Thu, 31 Jan 2019 11:44:00 +0100 Message-ID: Subject: Re: [PATCH bpf-next v3 2/3] libbpf: add support for using AF_XDP sockets To: Daniel Borkmann Cc: Magnus Karlsson , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , ast@kernel.org, Network Development , Jakub Kicinski , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , "Zhang, Qi Z" , Jesper Dangaard Brouer Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 31, 2019 at 11:07 AM Daniel Borkmann wrote: > > On 01/29/2019 04:12 PM, Magnus Karlsson wrote: > > This commit adds AF_XDP support to libbpf. The main reason for this is > > to facilitate writing applications that use AF_XDP by offering > > higher-level APIs that hide many of the details of the AF_XDP > > uapi. This is in the same vein as libbpf facilitates XDP adoption by > > offering easy-to-use higher level interfaces of XDP > > functionality. Hopefully this will facilitate adoption of AF_XDP, make > > applications using it simpler and smaller, and finally also make it > > possible for applications to benefit from optimizations in the AF_XDP > > user space access code. Previously, people just copied and pasted the > > code from the sample application into their application, which is not > > desirable. > > > > The interface is composed of two parts: > > > > * Low-level access interface to the four rings and the packet > > * High-level control plane interface for creating and setting > > up umems and af_xdp sockets as well as a simple XDP program. > > > > Signed-off-by: Magnus Karlsson > [...] > > libbpf ABI > > ========== > > > > diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map > > index 266bc95..d294843 100644 > > --- a/tools/lib/bpf/libbpf.map > > +++ b/tools/lib/bpf/libbpf.map > > @@ -121,6 +121,18 @@ LIBBPF_0.0.1 { > > libbpf_prog_type_by_name; > > libbpf_set_print; > > libbpf_strerror; > > + xsk_ring_cons__peek; > > + xsk_ring_cons__release; > > + xsk_ring_prod__reserve; > > + xsk_ring_prod__submit; > > + xsk_umem__get_data; > > + xsk_umem__get_data_raw; > > + xsk_umem__create; > > + xsk_socket__create; > > + xsk_umem__delete; > > + xsk_socket__delete; > > + xsk_umem__fd; > > + xsk_socket__fd; > > This definitely needs to be placed under LIBBPF_0.0.2 where we have bpf_probe_* > that were added in this cycle. OK. Will move it to LIBBPF_0.0.2. Thanks: Magnus > > > local: > > *; > > }; > > diff --git a/tools/lib/bpf/xsk.c b/tools/lib/bpf/xsk.c