From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EE75C7618F for ; Mon, 15 Jul 2019 21:44:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74A772086C for ; Mon, 15 Jul 2019 21:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563227088; bh=QhjAhcrBGIu89ZYNTAQunk1Pw0Bn7GPi6K8d8BScnIs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=wRFWGjEaNEao8wqVvAUpVZMDbrOXxfWpzjmJVqYtY+jjBwKUkWXo3j0URRB+4jpj9 sBWIgMgrsHhKu16bvtU75dBjIHQXjAu/cKWA4nwiKrECLuSrszNKfKIN3vvkRP9UOz 0OD+49x3c/1GduC99ggrwWemhT9TZDaBfaltGyPc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732645AbfGOVop (ORCPT ); Mon, 15 Jul 2019 17:44:45 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:41953 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731858AbfGOVop (ORCPT ); Mon, 15 Jul 2019 17:44:45 -0400 Received: by mail-ot1-f68.google.com with SMTP id o101so18695714ota.8; Mon, 15 Jul 2019 14:44:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hO2lc5/RCrOfroO8+pzsn6ZrqRVw3tFQDoLgNfzmBUQ=; b=QxXDGZ3v64gyAMTDqUN0aDnOZUEUriuNBjPSYo18FhopZ8P0hjPzAG+ZIKn7zH4gUi QQfKwc35vqrWxz9Pdos45CbPkxluZAY+xJxiCUnS/c8V3irYv3sVlFOGVsI03FOmIaXv 1EW+EKfby2IgVifnLuY8yMlV3B9g9zSRWk+MkjD42FojhmDrPbL1Gj05OvCQfmBMrtVC H2sgMK8MwEiq61UuGNkJPV+VQ+plnLtUXI5O8yARGzjtU/JH3OxAdhS+CBaJnz7jEarF rKc52Lygct/0tLMNo/N1pP0Qx0Vim/zzGg889XPO1TWBw/bRbhAqCy7vbi3fogYK9Wkn 2OSA== X-Gm-Message-State: APjAAAUsAOkRYO87kbLMCwaOxid9BCDbmnB2OvJG6nh20Bt2jxK632To Re3Z9R3uMSLoWgU/fV0rp3nL8QXeSGq3NMcP2Ik= X-Google-Smtp-Source: APXvYqxeBU+lL3PSYmxhb7JppIVz9aT6KKyGzUIDEJ8gGEzipFV4PQx8sL/9KU3ERl8XEJvsrjqZy4/vHGyUSxfUvR0= X-Received: by 2002:a05:6830:1516:: with SMTP id k22mr18941426otp.189.1563227084317; Mon, 15 Jul 2019 14:44:44 -0700 (PDT) MIME-Version: 1.0 References: <20190715143705.117908-1-joel@joelfernandes.org> <20190715143705.117908-9-joel@joelfernandes.org> In-Reply-To: <20190715143705.117908-9-joel@joelfernandes.org> From: "Rafael J. Wysocki" Date: Mon, 15 Jul 2019 23:44:31 +0200 Message-ID: Subject: Re: [PATCH 8/9] acpi: Use built-in RCU list checking for acpi_ioremaps list (v1) To: "Joel Fernandes (Google)" Cc: Linux Kernel Mailing List , Alexey Kuznetsov , Bjorn Helgaas , Borislav Petkov , c0d1n61at3@gmail.com, "David S. Miller" , edumazet@google.com, Greg Kroah-Hartman , Hideaki YOSHIFUJI , "H. Peter Anvin" , Ingo Molnar , Jonathan Corbet , Josh Triplett , Kees Cook , Kernel Hardening , "Cc: Android Kernel" , Lai Jiangshan , Len Brown , ACPI Devel Maling List , "open list:DOCUMENTATION" , Linux PCI , Linux PM , Mathieu Desnoyers , NeilBrown , netdev , Oleg Nesterov , "Paul E. McKenney" , Pavel Machek , Peter Zijlstra , "Rafael J. Wysocki" , Rasmus Villemoes , rcu@vger.kernel.org, Steven Rostedt , Tejun Heo , Thomas Gleixner , Will Deacon , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 15, 2019 at 4:43 PM Joel Fernandes (Google) wrote: > > list_for_each_entry_rcu has built-in RCU and lock checking. Make use of > it for acpi_ioremaps list traversal. > > Signed-off-by: Joel Fernandes (Google) Acked-by: Rafael J. Wysocki > --- > drivers/acpi/osl.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c > index 9c0edf2fc0dd..2f9d0d20b836 100644 > --- a/drivers/acpi/osl.c > +++ b/drivers/acpi/osl.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -80,6 +81,7 @@ struct acpi_ioremap { > > static LIST_HEAD(acpi_ioremaps); > static DEFINE_MUTEX(acpi_ioremap_lock); > +#define acpi_ioremap_lock_held() lock_is_held(&acpi_ioremap_lock.dep_map) > > static void __init acpi_request_region (struct acpi_generic_address *gas, > unsigned int length, char *desc) > @@ -206,7 +208,7 @@ acpi_map_lookup(acpi_physical_address phys, acpi_size size) > { > struct acpi_ioremap *map; > > - list_for_each_entry_rcu(map, &acpi_ioremaps, list) > + list_for_each_entry_rcu(map, &acpi_ioremaps, list, acpi_ioremap_lock_held()) > if (map->phys <= phys && > phys + size <= map->phys + map->size) > return map; > @@ -249,7 +251,7 @@ acpi_map_lookup_virt(void __iomem *virt, acpi_size size) > { > struct acpi_ioremap *map; > > - list_for_each_entry_rcu(map, &acpi_ioremaps, list) > + list_for_each_entry_rcu(map, &acpi_ioremaps, list, acpi_ioremap_lock_held()) > if (map->virt <= virt && > virt + size <= map->virt + map->size) > return map; > -- > 2.22.0.510.g264f2c817a-goog >