From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs Date: Sun, 21 Jul 2013 23:29:33 +0300 Message-ID: References: <20130617181004.GA1364@fedora-17-guest.dell.com> <20130711203938.GA4078@minipsycho.orion> <20130715153410.GA10864@fedora18-dev.oslab.blr.amer.dell.com> <20130721072455.GA1944@minipsycho.orion> <1374418103.16533.69.camel@deadeye.wl.decadent.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Jiri Pirko , Narendra_K@dell.com, netdev@vger.kernel.org, john.r.fastabend@intel.com To: Ben Hutchings Return-path: Received: from mail-qc0-f174.google.com ([209.85.216.174]:49810 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755822Ab3GUU3e (ORCPT ); Sun, 21 Jul 2013 16:29:34 -0400 Received: by mail-qc0-f174.google.com with SMTP id m15so3243667qcq.5 for ; Sun, 21 Jul 2013 13:29:33 -0700 (PDT) In-Reply-To: <1374418103.16533.69.camel@deadeye.wl.decadent.org.uk> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Jul 21, 2013 at 5:48 PM, Ben Hutchings wrote: > On Sun, 2013-07-21 at 14:14 +0300, Or Gerlitz wrote: >> On Sun, Jul 21, 2013 at 10:24 AM, Jiri Pirko wrote: >> [...] >> >> Sorry, I missed that fact that initially you responded on this thread >> >> > The value could be anything. But note that you have to have different >> > values for card1-port1,2 and card2-port1,2 >> >> why? > > The intent is to identify physical ports uniquely, so userland can tell > whether two devices are backed by the same physical port. OK this makes sense, and I understand that there are also some SRIOV aspects / use cases where this field could be usefu, still I don't understamd the direct relation to virtual functions, as mentioned in the 1st patch. > > But there's no requirement on the format, so you could ensure that one > byte of this identifier is the port number on the board. > > Ben. > > -- > Ben Hutchings, Staff Engineer, Solarflare > Not speaking for my employer; that's the marketing department's job. > They asked us to note that Solarflare product names are trademarked. >