From: Or Gerlitz <or.gerlitz@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Narendra_K@dell.com, bhutchings@solarflare.com,
netdev@vger.kernel.org, john.r.fastabend@intel.com
Subject: Re: [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs
Date: Mon, 22 Jul 2013 18:48:43 +0300 [thread overview]
Message-ID: <CAJZOPZLz9HBuOXj0hsrMOvQAVR=koL72-4GQUxY4G+tN-VKgSA@mail.gmail.com> (raw)
In-Reply-To: <20130722114944.GA1552@minipsycho.orion>
On Mon, Jul 22, 2013 at 2:49 PM, Jiri Pirko <jiri@resnulli.us> wrote:
> Mon, Jul 22, 2013 at 01:46:01PM CEST, Narendra_K@Dell.com wrote:
>>Would it be useful to embed the port number at a known offset to ensure
>>uniformity across all drivers, if a driver choses to embed port number
>>as part of phys_port_id ?
> I would not do that. Just let it be meaningless number. That is best for
> security reasons as well.
What's wrong with uniformity on port number or even on the overall concept?
Or.
prev parent reply other threads:[~2013-07-22 15:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 18:10 [PATCH net-next] net: Add phys_port identifier to struct net_device and export it to sysfs Narendra_K
2013-06-17 18:47 ` John Fastabend
2013-06-19 14:29 ` Narendra_K
2013-06-19 15:36 ` Ben Hutchings
2013-06-19 18:53 ` Narendra_K
2013-06-19 19:34 ` Ben Hutchings
2013-06-19 21:37 ` Praveen_Paladugu
2013-06-21 17:11 ` John Fastabend
2013-06-25 17:33 ` Narendra_K
2013-06-28 16:33 ` John Fastabend
2013-06-28 17:09 ` Ben Hutchings
2013-07-02 14:40 ` Narendra_K
2013-07-11 20:39 ` Jiri Pirko
2013-07-15 15:34 ` Narendra_K
2013-07-21 5:55 ` Or Gerlitz
2013-07-21 7:24 ` Jiri Pirko
2013-07-21 11:14 ` Or Gerlitz
2013-07-21 14:48 ` Ben Hutchings
2013-07-21 20:29 ` Or Gerlitz
2013-07-21 20:50 ` Ben Hutchings
2013-07-22 11:46 ` Narendra_K
2013-07-22 11:49 ` Jiri Pirko
2013-07-22 15:48 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZOPZLz9HBuOXj0hsrMOvQAVR=koL72-4GQUxY4G+tN-VKgSA@mail.gmail.com' \
--to=or.gerlitz@gmail.com \
--cc=Narendra_K@dell.com \
--cc=bhutchings@solarflare.com \
--cc=jiri@resnulli.us \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).