From: Or Gerlitz <or.gerlitz@gmail.com>
To: Tom Herbert <therbert@google.com>
Cc: Or Gerlitz <ogerlitz@mellanox.com>,
David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Jerry Chu <hkchu@google.com>, Eric Dumazet <edumazet@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Yan Burman <yanb@mellanox.com>,
Shlomo Pongratz <shlomop@mellanox.com>
Subject: Re: [PATCH net-next V4 3/3] net: Add GRO support for vxlan traffic
Date: Mon, 20 Jan 2014 13:40:38 +0200 [thread overview]
Message-ID: <CAJZOPZLzuCzcUmoc4ThM==rRAYywbdhECF72LAG_RPpq2WbOyw@mail.gmail.com> (raw)
In-Reply-To: <CAJZOPZJP7NGdQnHs1tVXny19w4mstEaEBi5WEvktZ4MumCfy0w@mail.gmail.com>
On Tue, Jan 14, 2014 at 11:47 PM, Or Gerlitz <or.gerlitz@gmail.com> wrote:
> On Tue, Jan 14, 2014 at 7:59 PM, Tom Herbert <therbert@google.com> wrote:
>> On Tue, Jan 14, 2014 at 8:00 AM, Or Gerlitz <ogerlitz@mellanox.com> wrote:
>> > Add GRO handlers for vxlann, by using the UDP GRO infrastructure.
>
> [...]
>>
>> > /* Notify netdevs that UDP port started listening */
>> > -static void vxlan_notify_add_rx_port(struct sock *sk)
>> > +static void vxlan_notify_add_rx_port(struct vxlan_sock *vs)
>> > {
>> > struct net_device *dev;
>> > + struct sock *sk = vs->sock->sk;
>> > struct net *net = sock_net(sk);
>> > sa_family_t sa_family = sk->sk_family;
>> > __be16 port = inet_sk(sk)->inet_sport;
>> > + int err;
>> > +
>> > + if (sa_family == AF_INET) {
>
>> Is this necessary? What about support for AF_INET6?
>
> Point taken -- the UDP GRO code for both ipv4 and ipv6 would work the same.
>
> So we can export udp_gro_receive/complete from net/ipv4/udp_offload.c
> such that they can be referred from net/ipv6/udp_offload.c
Hi Tom,
Spinning heads on this little more, it seems that the extension to IPv6 is
pretty much doable but needs little more work. I would prefer it to
be carried out
incrementally once the basic concept + IPv4 support, is merged.
So posting V5 now with the RCU directives set by Eric fixed.
Or.
next prev parent reply other threads:[~2014-01-20 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 16:00 [PATCH net-next V3 0/3] net: Add GRO support for UDP encapsulating protocols Or Gerlitz
2014-01-14 16:00 ` [PATCH net-next V4 1/3] " Or Gerlitz
2014-01-14 17:51 ` Tom Herbert
2014-01-14 21:51 ` Or Gerlitz
2014-01-15 0:50 ` Eric Dumazet
2014-01-14 16:00 ` [PATCH net-next V4 2/3] net: Export gro_find_by_type helpers Or Gerlitz
2014-01-14 16:00 ` [PATCH net-next V4 3/3] net: Add GRO support for vxlan traffic Or Gerlitz
2014-01-14 17:59 ` Tom Herbert
2014-01-14 21:47 ` Or Gerlitz
2014-01-20 11:40 ` Or Gerlitz [this message]
2014-01-14 16:06 ` [PATCH net-next V3 0/3] net: Add GRO support for UDP encapsulating protocols Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZOPZLzuCzcUmoc4ThM==rRAYywbdhECF72LAG_RPpq2WbOyw@mail.gmail.com' \
--to=or.gerlitz@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=hkchu@google.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=shlomop@mellanox.com \
--cc=therbert@google.com \
--cc=yanb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).