From: Xie He <xie.he.0141@gmail.com>
To: Eyal Birger <eyal.birger@gmail.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jason@zx2c4.com,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [net,v2] net/packet: fix packet receive on L3 devices without visible hard header
Date: Thu, 24 Dec 2020 02:06:44 -0800 [thread overview]
Message-ID: <CAJht_ENExFia=NPqYOmcF+kEFN8-YkAfUBuhzVEvPJwt0W4NZQ@mail.gmail.com> (raw)
In-Reply-To: <20201121062817.3178900-1-eyal.birger@gmail.com>
On Fri, Nov 20, 2020 at 10:28 PM Eyal Birger <eyal.birger@gmail.com> wrote:
>
> Fix by changing af_packet RX ll visibility criteria to include the
> existence of a '.create()' header operation, which is used when creating
> a device hard header - via dev_hard_header() - by upper layers, and does
> not exist in these L3 devices.
This patch changed the RX LL visibility criteria (in the comment) to
"dev_has_header". We need to change the TX LL visibility criteria (in
the same comment), too.
prev parent reply other threads:[~2020-12-24 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 6:28 [net,v2] net/packet: fix packet receive on L3 devices without visible hard header Eyal Birger
2020-11-21 7:51 ` Jason A. Donenfeld
2020-11-21 13:23 ` Willem de Bruijn
2020-11-24 2:58 ` Jakub Kicinski
2020-12-24 10:06 ` Xie He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJht_ENExFia=NPqYOmcF+kEFN8-YkAfUBuhzVEvPJwt0W4NZQ@mail.gmail.com' \
--to=xie.he.0141@gmail.com \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=eyal.birger@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).