From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43C91C433DF for ; Thu, 6 Aug 2020 17:29:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9243B221E3 for ; Thu, 6 Aug 2020 17:29:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LvvBqyfg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730456AbgHFR3j (ORCPT ); Thu, 6 Aug 2020 13:29:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728624AbgHFRAI (ORCPT ); Thu, 6 Aug 2020 13:00:08 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF738C0617A3; Thu, 6 Aug 2020 04:22:04 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id m34so166033pgl.11; Thu, 06 Aug 2020 04:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jnzzxc34cQW56LxwSyg5mi8Zc5YMYFPRJUcDt/n6b0U=; b=LvvBqyfgpeZFSNNkZU5lsH3pLnN3iLgCPYQiwOUywcijpSNbWn1VcotxvttMfFZZ/0 UEooSgKnM/46tX0dlW6rODlpbd70OlBc1b6QxBwLff+/AixsDfDV/LcDJTsVHqVmWVib 7JoeJiPKNeBlYli59nkZnoGA7CvxTwbmtgA43tH15RABrCfUbQTGKm9COuxDF2cVBXzo gUuxTBkMB1GUdaNl5WvzpQqYnVbhDA/LCSST/w/pdAN2Qgi/B41xGydKPVk27/AbcbSc HBOYygAnhNBzT5VBMtPYX0jdHiY0FqIKhNJcyJKpKVYBKZLo/LXuBD6uhx7k8DFGI9CP dBRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jnzzxc34cQW56LxwSyg5mi8Zc5YMYFPRJUcDt/n6b0U=; b=uaWF9Zc636jrZQmHa/el/gY2EZfBSJ/fJkzgMD9kmCTCKqKlbsbE7scSWO+OtYVo4g BxyjYInpyMNxLRzIrJ/qFlbf37TmAOy1C1LbeKqC1yK8msI4pP/MEdwJ6n5UxdhJObEu 6wRn1UVGyI5GhCqS0R55U83YhIJ8DeeA5ysnJKRQ9q3iIm0j54b7OFpPuKjSz52S5eLh Ol1Nrvt4O+i7LLtjo1tKwk61zrulapdirN4Cx4ccIDTXnDVZuAvDucgdzHSs7m7diQcD ZHXio+h7FnBMckadOj8Ax9XM0IRM/sjTw9ocVRe5yXS7xjpYRLMfMEdl03IG1lMFo7zH Mh9A== X-Gm-Message-State: AOAM5301TkgFAqwzZ6iTt6EOGo7bBdvGqCXtliWG3SwdiS5Ch01IY8EK N7+F9qbVocWeMPx9A5qbu1ZZKNzsqMPsiiYxD1TgUQ== X-Google-Smtp-Source: ABdhPJykwbb1OjxTXVBM34rrhJ4WhW/ws9Yx3vOWBNCofm/m7DTOL6oWsFpa9T4EXhuWQhhvqc+eGGA6Z1J+4Kc+R4Q= X-Received: by 2002:a63:e057:: with SMTP id n23mr6686076pgj.368.1596712924359; Thu, 06 Aug 2020 04:22:04 -0700 (PDT) MIME-Version: 1.0 References: <20200806015040.98379-1-xie.he.0141@gmail.com> In-Reply-To: From: Xie He Date: Thu, 6 Aug 2020 04:21:53 -0700 Message-ID: Subject: Re: [PATCH] drivers/net/wan/lapbether: Added needed_headroom and a skb->len check To: Willem de Bruijn Cc: "David S. Miller" , Jakub Kicinski , Network Development , linux-kernel , Linux X25 , Martin Schiller , Brian Norris Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Aug 6, 2020 at 12:47 AM Willem de Bruijn wrote: > > Acked-by: Willem de Bruijn > > The in-band signal byte is required, but stripped by lapbeth_xmit. > Subsequent code will prefix additional headers, including an Ethernet > link layer. The extra space needs to be reserved, but not pulled in > packet_snd with skb_reserve, so has to use needed_headroom instead of > hard_header_len. Thank you, Willem!