From: Xie He <xie.he.0141@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Network Development <netdev@vger.kernel.org>,
syzbot <syzbot+4a2c52677a8a1aa283cb@syzkaller.appspotmail.com>,
William Tu <u9012063@gmail.com>
Subject: Re: [Patch net] ip_gre: set dev->hard_header_len properly
Date: Fri, 9 Oct 2020 12:51:21 -0700 [thread overview]
Message-ID: <CAJht_EPVyc0uAZc914E3tdgqEc7tDabpAxnBsGrRRFecc+NMwg@mail.gmail.com> (raw)
In-Reply-To: <CAJht_ENnYyXbOxtPHD9GHB92U4uonKO_oRZ82g2OR2DaFZ7bBQ@mail.gmail.com>
On Fri, Oct 9, 2020 at 12:41 PM Xie He <xie.he.0141@gmail.com> wrote:
>
> Thanks. But there is still something that I don't understand. What is
> needed_headroom used for? If we are requesting space for t->encap_hlen
> and t->tun_hlen in hard_header_len. Do we still need to use
> needed_headroom?
It seems to me that the original code includes t->encap_hlen,
t->tun_hlen, and the IP header length in needed_headroom. (Right?) If
we are including these in hard_header_len, we need to move them out of
needed_headroom.
> Also, if we update hard_header_len or needed_headroom in
> ipgre_link_update, would there be racing issues if they are updated
> while skbs are being sent?
>
> If these are indeed issues, it might not be easy to fix this driver.
> Willem, do you have any thoughts?
next prev parent reply other threads:[~2020-10-09 20:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 1:21 [Patch net] ip_gre: set dev->hard_header_len properly Cong Wang
2020-10-08 11:48 ` Willem de Bruijn
2020-10-08 17:33 ` Cong Wang
2020-10-08 19:04 ` Willem de Bruijn
2020-10-08 19:16 ` Xie He
2020-10-08 19:19 ` Willem de Bruijn
2020-10-08 20:10 ` Xie He
2020-10-08 20:31 ` Willem de Bruijn
2020-10-08 21:35 ` Xie He
2020-10-08 21:47 ` Willem de Bruijn
2020-10-08 21:54 ` Xie He
2020-10-08 23:40 ` Xie He
2020-10-09 17:43 ` Cong Wang
2020-10-09 19:41 ` Xie He
2020-10-09 19:51 ` Xie He [this message]
2020-10-09 20:38 ` Cong Wang
2020-10-10 1:07 ` Cong Wang
2020-10-10 3:10 ` Xie He
2020-10-10 18:58 ` Cong Wang
2020-10-10 21:49 ` Xie He
2020-10-11 3:55 ` Xie He
2020-10-11 14:35 ` Xie He
2020-10-08 19:18 ` Willem de Bruijn
2020-10-08 19:50 ` Cong Wang
2020-10-08 20:19 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJht_EPVyc0uAZc914E3tdgqEc7tDabpAxnBsGrRRFecc+NMwg@mail.gmail.com \
--to=xie.he.0141@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=syzbot+4a2c52677a8a1aa283cb@syzkaller.appspotmail.com \
--cc=u9012063@gmail.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).