netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roopa Prabhu <roopa@cumulusnetworks.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: David Ahern <dsahern@gmail.com>, netdev <netdev@vger.kernel.org>,
	Ivan Vecera <ivecera@redhat.com>,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH iproute2 net-next v3 1/2] bridge: fdb get support
Date: Wed, 2 Oct 2019 09:07:17 -0700	[thread overview]
Message-ID: <CAJieiUhs1Hr-LxEhO7Keary3MwPWtWTwwhZ=1+5kiawfxRU4Pw@mail.gmail.com> (raw)
In-Reply-To: <20191001075928.26f1dd43@hermes.lan>

On Tue, Oct 1, 2019 at 7:59 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Mon, 30 Sep 2019 21:52:22 -0700
> Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
>
> > +
> > +     if (sscanf(addr, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
> > +                abuf, abuf+1, abuf+2,
> > +                abuf+3, abuf+4, abuf+5) != 6) {
> > +             fprintf(stderr, "Invalid mac address %s\n", addr);
> > +             return -1;
> > +     }
>
> You could use ether_aton here if that would help.
> Not required, but ether_ntoa already used in iplink_bridge.

ok ack, i will take a look. I think i picked this up from
bridge/fdb.c:fdb_modify

  reply	other threads:[~2019-10-02 16:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01  4:52 [PATCH iproute2 net-next v3 0/2] support for bridge fdb and neigh get Roopa Prabhu
2019-10-01  4:52 ` [PATCH iproute2 net-next v3 1/2] bridge: fdb get support Roopa Prabhu
2019-10-01 14:59   ` Stephen Hemminger
2019-10-02 16:07     ` Roopa Prabhu [this message]
2019-10-01  4:52 ` [PATCH iproute2 net-next v3 2/2] ipneigh: neigh " Roopa Prabhu
2019-10-01 15:30 ` [PATCH iproute2 net-next v3 0/2] support for bridge fdb and neigh get David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJieiUhs1Hr-LxEhO7Keary3MwPWtWTwwhZ=1+5kiawfxRU4Pw@mail.gmail.com' \
    --to=roopa@cumulusnetworks.com \
    --cc=dsahern@gmail.com \
    --cc=ivecera@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).