From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: Re: [PATCH net-next v4 1/3] ipv4: support sport, dport and ip_proto
 in RTM_GETROUTE
Date: Tue, 22 May 2018 08:45:49 -0700
Message-ID: <CAJieiUjvpR-QmPifBDUoWsWVWHBCtp8_pDzjba9s21-Fyv4=0w@mail.gmail.com>
References: <1527000668-25253-1-git-send-email-roopa@cumulusnetworks.com>
 <1527000668-25253-2-git-send-email-roopa@cumulusnetworks.com> <9e2a1bc7-e80a-1642-3b83-2341fddc6097@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
        David Ahern <dsa@cumulusnetworks.com>,
        Ido Schimmel <idosch@mellanox.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-vk0-f65.google.com ([209.85.213.65]:43680 "EHLO
        mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751196AbeEVPpu (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 22 May 2018 11:45:50 -0400
Received: by mail-vk0-f65.google.com with SMTP id x191-v6so11192874vke.10
        for <netdev@vger.kernel.org>; Tue, 22 May 2018 08:45:50 -0700 (PDT)
In-Reply-To: <9e2a1bc7-e80a-1642-3b83-2341fddc6097@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, May 22, 2018 at 8:04 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>
> On 05/22/2018 07:51 AM, Roopa Prabhu wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>>
>
> ...
>
>> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
>> index 4d622112..cf5cfc5 100644
>> --- a/net/ipv4/fib_frontend.c
>> +++ b/net/ipv4/fib_frontend.c
>> @@ -649,6 +649,10 @@ const struct nla_policy rtm_ipv4_policy[RTA_MAX + 1] = {
>>       [RTA_ENCAP]             = { .type = NLA_NESTED },
>>       [RTA_UID]               = { .type = NLA_U32 },
>>       [RTA_MARK]              = { .type = NLA_U32 },
>> +     [RTA_TABLE]             = { .type = NLA_U32 },
>> +     [RTA_IP_PROTO]          = { .type = NLA_U8 },
>> +     [RTA_SPORT]             = { .type = NLA_U16 },
>> +     [RTA_DPORT]             = { .type = NLA_U16 },
>>  };
>
> Hi Roopa
>
> RTA_TABLE addition looks like a bug fix for net tree ?
>
> This should be sent as an independent patch IMO.
>
> Thanks.

sure, I can do that. thanks.