From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16846C31E45 for ; Thu, 13 Jun 2019 17:53:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4F342063F for ; Thu, 13 Jun 2019 17:53:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ppvRcj2f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726915AbfFMRxR (ORCPT ); Thu, 13 Jun 2019 13:53:17 -0400 Received: from mail-qt1-f174.google.com ([209.85.160.174]:34543 "EHLO mail-qt1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725886AbfFMRxQ (ORCPT ); Thu, 13 Jun 2019 13:53:16 -0400 Received: by mail-qt1-f174.google.com with SMTP id m29so23592765qtu.1 for ; Thu, 13 Jun 2019 10:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=Uy066ZV7bgAktFEXl4WYIMVfekGzUJn9sDijeqz/6js=; b=ppvRcj2fAvxAjLvxfx37Nx8VsHo8Zn84KOQIFwh3nkP68zAI/pJDwz6o+YNhmCDWpC laWqQisfVdfx2bN6+IhaVNLtv8THGpCBPvW+VImBxk0zY+NeB+TlvnaXYp6DhIpFoBPN IkFrKZ80Tns1S8o/GZbrf65MFIq96UYTVnMUn1FaaHizgbOVBQaQZye0boOknbXmnV6M rKvLk9s4eqUb3iVqdbNIwm66vxO1yDPZEdoq2VbCNlg+HlmFXN944pX1IJGXvEC7qY4L wqI+ptqVTFF3HIUDO/xsLq1v8WBE/f7srOOfnwPoachOPpzn2nYvPkLJZWggfYaa9qoD uayQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=Uy066ZV7bgAktFEXl4WYIMVfekGzUJn9sDijeqz/6js=; b=mhOydPEg2Mz3OmKNrLtxNcZk97gmG4NPPAFjjrte2TlWea0rOyDbzyNQwDo6lCWaPp 9Soo4YBwWicSWrM07idbcIoydKnJ1GHq90+3Zfsh8r//CGLCFKkupsZtFBAks0AR8TtO tg1Ds1A8T6t4Ue7sMLVOb+nXsp6CUAEy0Ph9MPKn2VFR1jHUhwozlOpgyC3cbeX+8AcN MgxB5q1ZK78wWAUeyYJr/LBSMQJaufVWBsxjeu1wOa2VN9+4wUmVAb/c7CsdbmhSnfq8 XlQV8MGanaThu8ox2LztBpnybHRSoh+Sz0Jn1HH73XDZP2XpS1o/Z1BNtSc9qOzF9bwB ygOQ== X-Gm-Message-State: APjAAAX4X2tWUDutMzion7aSqWxvqpHlkbdhaJe9eWoPSCtoJ6uh0YrD 97GB3S2U7jpoK2sNnjyHOaCahx/389nMlzIToQLJRG7i1T7Y3w== X-Google-Smtp-Source: APXvYqzkT447i3R9IhbIClKX63YPdh9gzEn8y6slBvWgGiQka3EvlzqGEoCmY/PUe8lHb4NKJjMoQgPBaSXMEsnpq/w= X-Received: by 2002:a0c:8a23:: with SMTP id 32mr4732749qvt.231.1560448395630; Thu, 13 Jun 2019 10:53:15 -0700 (PDT) MIME-Version: 1.0 From: Nathan Huckleberry Date: Thu, 13 Jun 2019 10:53:05 -0700 Message-ID: Subject: Cleanup of -Wunused-const-variable in drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c To: maxime.chevallier@bootlin.com, davem@davemloft.net Cc: netdev@vger.kernel.org, clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hey all, I'm looking into cleaning up ignored warnings in the kernel so we can remove compiler flags to ignore warnings. There's an unused variable 'mvpp2_dbgfs_prs_pmap_fops' in mvpp2_debugfs.c. It looks like this code is for dumping useful information into userspace. I'd like to either remove the variable or dump it to userspace in the same way the other variables are. Wanted to reach out for opinions on the best course of action before submitting a patch. https://github.com/ClangBuiltLinux/linux/issues/529 Thanks, Nathan Huckleberry