From: Luiz Angelo Daros de Luca <luizluca@gmail.com>
To: "Alvin Šipraga" <alvin@pqrs.dk>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Michael Rasmussen" <mir@bang-olufsen.dk>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Arınç ÜNAL" <arinc.unal@arinc9.com>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] net: dsa: realtek: fix PHY register read corruption
Date: Wed, 16 Feb 2022 14:57:11 -0300 [thread overview]
Message-ID: <CAJq09z6Mr7QFSyqWuM1jjm9Dis4Pa2A4yi=NJv1w4FM0WoyqtA@mail.gmail.com> (raw)
In-Reply-To: <20220216160500.2341255-1-alvin@pqrs.dk>
> These two patches fix the issue reported by Arınç where PHY register
> reads sometimes return garbage data.
>
> MAINTAINERS: Please can you help me with the targetting of these two
> patches? This bug is present ca. 5.16, when the SMI version of the
> rtl8365mb driver was introduced. But now in net-next we have the MDIO
> interface from Luiz, where the issue is also present. I am sending what
> I think is an ideal patch series, but should I split it up and send the
> SMI-related changes to net and the MDIO changes to net-next? If so, how
> would I go about splitting it while preventing merge conflicts and build
> errors?
>
> For now I am sending it to net-next so that the whole thing can be
> reviewed. If it's applied, I would gladly backport the fix to the stable
> tree for 5.16, but I am still confused about what to do for 5.17.
>
> Thanks for your help.
>
>
> Alvin Šipraga (2):
> net: dsa: realtek: allow subdrivers to externally lock regmap
> net: dsa: realtek: rtl8365mb: serialize indirect PHY register access
>
> drivers/net/dsa/realtek/realtek-mdio.c | 46 +++++++++++++++++++++-
> drivers/net/dsa/realtek/realtek-smi.c | 48 +++++++++++++++++++++--
> drivers/net/dsa/realtek/realtek.h | 2 +
> drivers/net/dsa/realtek/rtl8365mb.c | 54 ++++++++++++++++----------
> 4 files changed, 124 insertions(+), 26 deletions(-)
>
> --
> 2.35.0
>
Thanks for the fix, Alvin.
I still feel like we are trying to go around a regmap limitation
instead of fixing it there. If we control regmap lock (we can define a
custom lock/unlock) and create new regmap_{read,write}_nolock
variants, we'll just need to lock the regmap, do whatever you need,
and unlock it.
BTW, I believe that, for realtek-mdio, a regmap custom lock mechanism
could simply use mdio lock while realtek-smi already has priv->lock.
Regards,
next prev parent reply other threads:[~2022-02-16 17:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 16:04 [PATCH net-next 0/2] net: dsa: realtek: fix PHY register read corruption Alvin Šipraga
2022-02-16 16:04 ` [PATCH net-next 1/2] net: dsa: realtek: allow subdrivers to externally lock regmap Alvin Šipraga
2022-02-16 16:05 ` [PATCH net-next 2/2] net: dsa: realtek: rtl8365mb: serialize indirect PHY register access Alvin Šipraga
2022-02-16 23:39 ` Vladimir Oltean
2022-02-17 3:01 ` Luiz Angelo Daros de Luca
2022-02-17 8:16 ` Alvin Šipraga
2022-02-22 0:18 ` Luiz Angelo Daros de Luca
2022-02-17 7:41 ` Alvin Šipraga
2022-02-17 11:17 ` Vladimir Oltean
2022-02-17 12:51 ` Alvin Šipraga
2022-02-21 14:50 ` Alvin Šipraga
2022-02-21 17:15 ` Vladimir Oltean
2022-02-21 18:10 ` Alvin Šipraga
2022-02-16 17:57 ` Luiz Angelo Daros de Luca [this message]
2022-02-16 18:23 ` [PATCH net-next 0/2] net: dsa: realtek: fix PHY register read corruption Alvin Šipraga
2022-02-16 19:11 ` Andrew Lunn
2022-02-16 19:26 ` Alvin Šipraga
2022-02-17 12:12 ` Andrew Lunn
2022-02-17 13:09 ` Alvin Šipraga
2022-02-17 13:32 ` Andrew Lunn
2022-02-17 4:28 ` Luiz Angelo Daros de Luca
2022-02-17 7:53 ` Alvin Šipraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJq09z6Mr7QFSyqWuM1jjm9Dis4Pa2A4yi=NJv1w4FM0WoyqtA@mail.gmail.com' \
--to=luizluca@gmail.com \
--cc=alsi@bang-olufsen.dk \
--cc=alvin@pqrs.dk \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mir@bang-olufsen.dk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).