Netdev Archive on lore.kernel.org
 help / color / Atom feed
From: John Hurley <john.hurley@netronome.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Jiri Pirko <jiri@mellanox.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Davide Caratti <dcaratti@redhat.com>,
	Simon Horman <simon.horman@netronome.com>,
	Jakub Kicinski <jakub.kicinski@netronome.com>,
	oss-drivers@netronome.com
Subject: Re: [PATCH net-next v2 1/3] net: sched: add mpls manipulation actions to TC
Date: Fri, 14 Jun 2019 12:59:41 +0100
Message-ID: <CAK+XE=nojwLVmTd+LcAz8corC6zJD5SkVUSraW-FK3f3kAZK4Q@mail.gmail.com> (raw)
In-Reply-To: <20190614081004.GC2242@nanopsycho>

On Fri, Jun 14, 2019 at 9:10 AM Jiri Pirko <jiri@resnulli.us> wrote:
>
> Thu, Jun 13, 2019 at 07:43:57PM CEST, john.hurley@netronome.com wrote:
> >Currently, TC offers the ability to match on the MPLS fields of a packet
> >through the use of the flow_dissector_key_mpls struct. However, as yet, TC
> >actions do not allow the modification or manipulation of such fields.
> >
> >Add a new module that registers TC action ops to allow manipulation of
> >MPLS. This includes the ability to push and pop headers as well as modify
> >the contents of new or existing headers. A further action to decrement the
> >TTL field of an MPLS header is also provided.
> >
> >Signed-off-by: John Hurley <john.hurley@netronome.com>
> >Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>
> [...]
>
>
> >+              if (tb[TCA_MPLS_LABEL] || tb[TCA_MPLS_TTL] || tb[TCA_MPLS_TC]) {
> >+                      NL_SET_ERR_MSG_MOD(extack,
> >+                                         "MPLS POP: unsupported attrs");
>
> No need to break line here and couple other similar places in this code.
> Anyway, looks good otherwise:
>

Ok, let me respin with these line breaks removed.
I'll also retract patch 2 and repost when driver changes are there.
Thanks


> Acked-by: Jiri Pirko <jiri@mellanox.com>
>
> [...]

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-13 17:43 [PATCH net-next v2 0/3] Add MPLS " John Hurley
2019-06-13 17:43 ` [PATCH net-next v2 1/3] net: sched: add mpls manipulation " John Hurley
2019-06-14  8:10   ` Jiri Pirko
2019-06-14 11:59     ` John Hurley [this message]
2019-06-14 16:59   ` Cong Wang
2019-06-14 22:56     ` John Hurley
2019-06-17 21:18       ` Cong Wang
2019-06-17 22:09         ` John Hurley
2019-06-13 17:43 ` [PATCH net-next v2 2/3] net: sched: include mpls actions in hardware intermediate representation John Hurley
2019-06-14  8:11   ` Jiri Pirko
2019-06-13 17:43 ` [PATCH net-next v2 3/3] selftests: tc-tests: actions: add MPLS tests John Hurley

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK+XE=nojwLVmTd+LcAz8corC6zJD5SkVUSraW-FK3f3kAZK4Q@mail.gmail.com' \
    --to=john.hurley@netronome.com \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jiri@mellanox.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    --cc=simon.horman@netronome.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org netdev@archiver.kernel.org
	public-inbox-index netdev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox