From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ECB7C56201 for ; Mon, 23 Nov 2020 03:37:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF0E120DD4 for ; Mon, 23 Nov 2020 03:37:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="ooQtKrxm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727339AbgKWDhf (ORCPT ); Sun, 22 Nov 2020 22:37:35 -0500 Received: from conssluserg-06.nifty.com ([210.131.2.91]:60881 "EHLO conssluserg-06.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726885AbgKWDhf (ORCPT ); Sun, 22 Nov 2020 22:37:35 -0500 X-Greylist: delayed 114773 seconds by postgrey-1.27 at vger.kernel.org; Sun, 22 Nov 2020 22:37:34 EST Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (authenticated) by conssluserg-06.nifty.com with ESMTP id 0AN3atLh032027; Mon, 23 Nov 2020 12:36:56 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-06.nifty.com 0AN3atLh032027 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1606102616; bh=YL64JWX8+POTNkn/GZ7B+nszuW5O8YQqSfoss8+OVhk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ooQtKrxm1EI5JJsobUKyeYXAjIV+RoefFSoPmKabq0sodI0Y1kw+Yxf5jMgOU3v1w W5HSJfgC7Ej7Hg80VGtMAFcmNyxPtUQaK73w6lhwLwGliH3flZ7yc57MtqiU0FIx1m 6ei0KbX+XgpmmGOGSBQzYwXM2775PqN2AfMu9nvZqWvl9UpfrzAvVIN8/t7ILYBwYH 45J1SGSHpQVjwYtVGtQYTkEn2Kr42iG243csfHSuHHxaWZznhqAqqXpo8QhOA2CISk fTy4GoIZHjWNKw1q5jrUotX5w6+Bpqm4pJdEapeAZihlZrCYUbcY4lRZB9/0cdKDIn 5Z0iWPVnvOMWg== X-Nifty-SrcIP: [209.85.214.174] Received: by mail-pl1-f174.google.com with SMTP id p6so5794187plr.7; Sun, 22 Nov 2020 19:36:55 -0800 (PST) X-Gm-Message-State: AOAM531WfhrVdtMP9OyP5ISyB7HQDflJ/SYNzwEHso0Q801m5Q3ktDC6 0MTESIXBhHJtfiI9lAS6ceYpFz0FcBrgmLPCrqE= X-Google-Smtp-Source: ABdhPJzNuqDamg2p4M+v2AI8oS/thdIABCwyrr94QP7NGfbG5kGWuCZOsctgZMaDSWL8YqmDoi92WL62fYY5d0QrEd4= X-Received: by 2002:a17:902:ff0e:b029:d6:820d:cb81 with SMTP id f14-20020a170902ff0eb02900d6820dcb81mr22899656plj.47.1606102615011; Sun, 22 Nov 2020 19:36:55 -0800 (PST) MIME-Version: 1.0 References: <20201121194339.52290-1-masahiroy@kernel.org> In-Reply-To: From: Masahiro Yamada Date: Mon, 23 Nov 2020 12:36:18 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK To: Miguel Ojeda Cc: "Jason A. Donenfeld" , Shuah Khan , linux-kernel , "open list:KERNEL SELFTEST FRAMEWORK" , Network Development , wireguard@lists.zx2c4.com, clang-built-linux , Nick Desaulniers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Nov 22, 2020 at 5:45 AM Miguel Ojeda wrote: > > On Sat, Nov 21, 2020 at 8:44 PM Masahiro Yamada wrote: > > > > Our goal is to always enable __must_check where appreciate, so this > > CONFIG option is no longer needed. > > This would be great. It also implies we can then move it to > `compiler_attributes.h` since it does not depend on config options > anymore. > > We should also rename it to `__nodiscard`, since that is the > standardized name (coming soon to C2x and in C++ for years). > > Cc'ing the Clang folks too to make them aware. > I can move it to compiler_attribute.h This attribute is supported by gcc, clang, and icc. https://godbolt.org/z/ehd6so I can send v2. I do not mind renaming, but it should be done in a separate patch. -- Best Regards Masahiro Yamada