netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: James Carlson <carlsonj@workingcode.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Doug Brown <doug@schmorgal.com>,
	Jakub Kicinski <kuba@kernel.org>,
	David Miller <davem@davemloft.net>,
	Networking <netdev@vger.kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	linux-ppp@vger.kernel.org
Subject: Re: [PATCH net-next] net: appletalk: remove Apple/Farallon LocalTalk PC support
Date: Thu, 12 May 2022 21:21:50 +0200	[thread overview]
Message-ID: <CAK8P3a0xmXYU5iNki3BX25J73jcy+xJ=bf67G6PqAHjRwckFRA@mail.gmail.com> (raw)
In-Reply-To: <0078ff43-f9fa-1deb-b64d-170d3d93ee6f@workingcode.com>

On Thu, May 12, 2022 at 8:11 PM James Carlson <carlsonj@workingcode.com> wrote:
>
> On 5/11/22 04:23, Arnd Bergmann wrote:
> > indication of appletalk ever being supported there, this all looks
> > IPv4/IPv6 specific. There was support for PPP_IPX until it was
> > dropped this year (the kernel side got removed in 2018), but never
> > for PPP_AT.
> > Adding Paul Mackerras to Cc, he might know more about it.
>
> I waited a bit before chipping in, as I think Paul would know more.
>
> The ATCP stuff was in at least a few vendor branches, but I don't think
> it ever made it into the main distribution. These commits seem to be
> where the (disabled by default) references to it first appeared:
>
> commit 50c9469f0f683c7bf8ebad9b7f97bfc03c6a4122
> Author: Paul Mackerras <paulus@samba.org>
> Date:   Tue Mar 4 03:32:37 1997 +0000
>
>     add defs for appletalk
>
> commit 01548ef15e0f41f9f6af33860fb459a7f578f004
> Author: Paul Mackerras <paulus@samba.org>
> Date:   Tue Mar 4 03:41:17 1997 +0000
>
>     connect time stuff gone to auth.c,
>     don't die on EINTR from opening tty,
>     ignore NCP packets during authentication,
>     fix recursive signal problem in kill_my_pg

Right, I had seen those in the git history, but neither of them actually
does anything with appletak.

> The disabled-by-default parts were likely support contributions for
> those other distributions. (Very likely in BSD.)
>
> I would've thought AppleTalk was completely gone by now, and I certainly
> would not be sad to see the dregs removed from pppd, but there was a
> patch release on the netatalk package just last month, so what do I know?

I think netatalk 3.0 dropped all appletalk protocol stuff a long time ago and
only supports AFP over IP.

         Arnd

  reply	other threads:[~2022-05-12 19:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 15:01 [PATCH net-next] net: appletalk: remove Apple/Farallon LocalTalk PC support Jakub Kicinski
2022-05-09 17:14 ` Arnd Bergmann
2022-05-09 17:32   ` Jakub Kicinski
2022-05-10  2:34     ` Doug Brown
2022-05-10  6:48       ` Arnd Bergmann
2022-05-11  0:20         ` Doug Brown
2022-05-11  8:23           ` Arnd Bergmann
2022-05-12 18:11             ` James Carlson
2022-05-12 19:21               ` Arnd Bergmann [this message]
2022-05-12 19:28                 ` Doug Brown
2022-05-11 12:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a0xmXYU5iNki3BX25J73jcy+xJ=bf67G6PqAHjRwckFRA@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=carlsonj@workingcode.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=doug@schmorgal.com \
    --cc=edumazet@google.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ppp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).