From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E33C6379F for ; Wed, 28 Oct 2020 22:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 609D4206D9 for ; Wed, 28 Oct 2020 22:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603923556; bh=tR5T1ixXSQsN1p3RFSnnK5n87sXC6NvZ2LmyQ9KYqew=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ZG100MaSy1GBtX5KW1n5MtrQbYCjgN5Wju6GnZu3H7hDhCVZGRSAWvXzaHCahxb97 s5phbU4E5cpXb7gOnzBjn7xsEsJmTEEJqFMBlWB3vZ842r2QN9r7GSTsMsLZOf5snR zfYJhxaBh9toUZVsgDy+rDdPIXi7ilMI53gezqec= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731811AbgJ1WTO (ORCPT ); Wed, 28 Oct 2020 18:19:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:60514 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731697AbgJ1WRl (ORCPT ); Wed, 28 Oct 2020 18:17:41 -0400 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B599724658; Wed, 28 Oct 2020 08:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603874169; bh=tR5T1ixXSQsN1p3RFSnnK5n87sXC6NvZ2LmyQ9KYqew=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WMDLNdKLDhqkIvvJH7y8KwUNKg5yd3myAMFox9dG+dZuCpFin9ejEFcjuJUpvDDeZ sCP0aRhfXzzXZ/kgfl5VCvoAfvZLKFBZrw6QpyFlC+S/xoWXYfgpRhcvWBdExx1qUP FWwryo469rY/80saP+7qRULEonovseMm0snoC0Ew= Received: by mail-qt1-f178.google.com with SMTP id r8so2971777qtp.13; Wed, 28 Oct 2020 01:36:09 -0700 (PDT) X-Gm-Message-State: AOAM530BjIW6XJjY3Q3HdzaoSIHrnSCWrPEMVnkq+hRb8J+XsU7yF+9X 9qCTLKu6Q+7Ra/yniLPgk/VJhacwnyJ3WzPs/Co= X-Google-Smtp-Source: ABdhPJyvQK7A6eVqNlZh9SImBHOPgfZPetL/xuQ/QKJ2RTER9SX+SnPDHfWDJLbNIPOIGFTtguwvTzfUSnxARr0lfRM= X-Received: by 2002:ac8:7b33:: with SMTP id l19mr5954088qtu.304.1603874168761; Wed, 28 Oct 2020 01:36:08 -0700 (PDT) MIME-Version: 1.0 References: <20201026213040.3889546-1-arnd@kernel.org> <20201027174226.4bd50144@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201027174226.4bd50144@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Arnd Bergmann Date: Wed, 28 Oct 2020 09:35:52 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next 01/11] atm: horizon: shut up clang null pointer arithmetic warning To: Jakub Kicinski Cc: Chas Williams <3chas3@gmail.com>, Nathan Chancellor , Nick Desaulniers , "David S. Miller" , linux-atm-general@lists.sourceforge.net, Networking , "linux-kernel@vger.kernel.org" , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Oct 28, 2020 at 1:42 AM Jakub Kicinski wrote: > > On Mon, 26 Oct 2020 22:29:48 +0100 Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > Building a "W=1" kernel with clang produces a warning about > > suspicous pointer arithmetic: > > > > drivers/atm/horizon.c:1844:52: warning: performing pointer arithmetic > > on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > > for (mem = (HDW *) memmap; mem < (HDW *) (memmap + 1); ++mem) > > > > The way that the addresses are handled is very obscure, and > > rewriting it to be more conventional seems fairly pointless, given > > that this driver probably has no users. > > Shut up this warning by adding a cast to uintptr_t. > > > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > Signed-off-by: Arnd Bergmann > > Hi! > > I'm not sure what your plan is for re-spinning but when you do could > you please split the wireless changes out? Sure, will do. The easiest for me would be if you just merge the ones that have been acked or that look obvious enough for you, and I'll then resend whatever is left after addressing the review comments. If that causes you extra work, I'll just send everything that should go through your tree. > Also we never got patch 3 > IDK if that's a coincidence or if it wasn't for networking... Yes, that one slipped in when I was sorting my longer series, it was a block driver change. Arnd